Skip to content

[EE] No machine type on new pipeline #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AleksandarCole opened this issue Mar 28, 2025 · 0 comments
Closed

[EE] No machine type on new pipeline #187

AleksandarCole opened this issue Mar 28, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@AleksandarCole
Copy link
Collaborator

Describe the bug

Creating a new pipeline in Workflow builder results in the empty machine type parameter, in turn making the pipeline invalid.

As an alternative solution, on the self-hosted versions of Semaphore, when new pipeline is created the machine type should be set to the first available machine, and environment to Docker fixed values.

So it would look something like:

agent:
  machine:
    type: <FIRST AGENT IN THE LIST>
    os_image: ''
  containers:
    - name: main
      image: 'semaphoreci/ubuntu:20.04'

Steps to reproduce

  1. Open the EE version of Semaphore
  2. In existing project, open the workflow editor
  3. Click on "+ Add Promotion" button to create a new pipeline
  4. Run the workflow
  5. Observe the error
  6. Check the promotion pipeline yaml file

Additional context

⚠️ This happens only on the EE version

@AleksandarCole AleksandarCole added the bug Something isn't working label Mar 28, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Roadmap Mar 28, 2025
@AleksandarCole AleksandarCole added this to the 2025 - April milestone Mar 28, 2025
@skipi skipi moved this from Backlog to Todo in Roadmap Mar 28, 2025
@lucianoliberti lucianoliberti assigned dexyk and unassigned skipi Mar 28, 2025
dexyk added a commit that referenced this issue Apr 1, 2025
## 📝 Description

**Fixes** #187

This PR introduces the following improvements:
- Sets the default machine type to the first available self-hosted agent
type.
- Sets the default container image for promotions that use Docker
environments.

### Behavior

- **Self-hosted agent default:**  
When adding a promotion with a block (without overriding global agent
definition), the first available self-hosted agent is selected by
default.
![Self-hosted
default](https://github.com/user-attachments/assets/e53199c0-c9a5-4d41-8256-16db1e3b1a04)

- **Docker environment default:**  
When adding a promotion with a block that uses a Docker environment, the
default container image is automatically set.
![Docker image
default](https://github.com/user-attachments/assets/e9cd7420-7a3b-4e86-8e35-0bb6c96617e9)


## ✅ Checklist
- [x] I have tested this change
- [x] ~This change requires documentation update~ - N/A
@lucianoliberti lucianoliberti moved this from Todo to Ready in Roadmap Apr 1, 2025
skipi pushed a commit that referenced this issue Apr 14, 2025
## 📝 Description

**Fixes** #187

This PR introduces the following improvements:
- Sets the default machine type to the first available self-hosted agent
type.
- Sets the default container image for promotions that use Docker
environments.

### Behavior

- **Self-hosted agent default:**  
When adding a promotion with a block (without overriding global agent
definition), the first available self-hosted agent is selected by
default.
![Self-hosted
default](https://github.com/user-attachments/assets/e53199c0-c9a5-4d41-8256-16db1e3b1a04)

- **Docker environment default:**  
When adding a promotion with a block that uses a Docker environment, the
default container image is automatically set.
![Docker image
default](https://github.com/user-attachments/assets/e9cd7420-7a3b-4e86-8e35-0bb6c96617e9)


## ✅ Checklist
- [x] I have tested this change
- [x] ~This change requires documentation update~ - N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

3 participants