Skip to content

Developer experience guidelines #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Developer experience guidelines #356

merged 2 commits into from
Jun 9, 2025

Conversation

skipi
Copy link
Contributor

@skipi skipi commented Jun 5, 2025

📝 Description

Part of #337

✅ Checklist

  • I have tested this change
  • This change requires documentation update

@skipi skipi requested review from TomFern and VeljkoMaksimovic June 5, 2025 09:21
@skipi skipi force-pushed the mk/contribution-guidelines branch from e08c0e8 to 2a58671 Compare June 5, 2025 09:23
TomFern
TomFern previously approved these changes Jun 5, 2025
Copy link
Contributor

@radwo radwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one note here, dev containers are not limited only to VS Code. What do you think of updating the info that dev containers are supported, and only mention that you can use VS Code to run them? Currently it sounds as you should use it because there is no other way to run containers.

@skipi
Copy link
Contributor Author

skipi commented Jun 9, 2025

I have one note here, dev containers are not limited only to VS Code. What do you think of updating the info that dev containers are supported, and only mention that you can use VS Code to run them? Currently it sounds as you should use it because there is no other way to run containers.

Makes perfect sense. I'll update the guidelines.

@skipi skipi force-pushed the mk/contribution-guidelines branch 4 times, most recently from 776f087 to cdecf17 Compare June 9, 2025 08:24
@skipi skipi marked this pull request as ready for review June 9, 2025 08:24
@skipi skipi requested review from radwo and TomFern June 9, 2025 08:24
@skipi skipi changed the title wip: contribution guidelines Developer experience guidelines Jun 9, 2025
@skipi skipi force-pushed the mk/contribution-guidelines branch from cdecf17 to 0b94f70 Compare June 9, 2025 08:47
@skipi skipi enabled auto-merge (squash) June 9, 2025 09:48
@skipi skipi merged commit bf1215d into main Jun 9, 2025
2 checks passed
@skipi skipi deleted the mk/contribution-guidelines branch June 9, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants