Dev/consolidate services #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radwo
reviewed
Jun 5, 2025
There was a problem hiding this comment.
There is an inconsistency in naming here: on one hand, you have minimalDeployment, and on the other, local-dev and LOCAL_DEV_ENV. It would be better to keep the naming consistent to avoid confusion later.
Also, I think minimalDeployment is a better choice than local-dev, since someone might want to run this on a small production server with minimal traffic.
VeljkoMaksimovic
requested review from
lucaspin,
hamir-suspect,
DamjanBecirovic,
dexyk,
skipi and
forestileao
as code owners
hamir-suspect
approved these changes
Jun 10, 2025
skipi
approved these changes
Jun 10, 2025
dexyk
approved these changes
Jun 10, 2025
lucaspin
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
When running services using skaffold dev, consolidate different microservices into singular deployment
https://github.com/renderedtext/project-tasks/issues/2417
✅ Checklist