Skip to content

Update types to allow discriminated union #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamieS1211 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update types to allow discriminated union #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update types to allow discriminated union
  • Loading branch information
@JamieS1211
JamieS1211 committed Feb 22, 2020
commit eb677af1e69b03ecddf9db470c0c7aebb700baf0
4 changes: 3 additions & 1 deletion SendBird.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ declare namespace SendBird {
channelUrl: string;
channelType: string;
messageId: number;
messageType: string;
data: string;
customType: string;
metaArrays: Array<MessageMetaArray>;
Expand All @@ -310,6 +309,7 @@ declare namespace SendBird {
}

interface AdminMessage extends BaseMessageInstance {
messageType: "admin";
message: string;
translations: Object;
}
Expand Down Expand Up @@ -337,6 +337,7 @@ declare namespace SendBird {
pushNotificationDeliveryOption: "default" | "suppress";
}
interface UserMessage extends BaseMessageInstance {
messageType: "user";
message: string;
sender: Sender;
reqId: string;
Expand Down Expand Up @@ -367,6 +368,7 @@ declare namespace SendBird {
pushNotificationDeliveryOption: "default" | "suppress";
}
interface FileMessage extends BaseMessageInstance {
messageType: "file";
sender: Sender;
reqId: string;
url: string;
Expand Down