Skip to content

Sync with SendBirdWebRTC 1.1.1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2020
Merged

Sync with SendBirdWebRTC 1.1.1 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c65f732
Enable VP9 and Bitcode. Lower iOS Deployment Target to 9.0
mininny May 25, 2020
a99334c
Make RTCStatistics public
mininny May 25, 2020
bb46add
Update gitignore
mininny May 25, 2020
d13ef15
Update README.md
mininny May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,3 +71,4 @@
/xcodebuild
/.vscode
!webrtc/*
out_ios_libs
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
This repository is a private branch of [Google's WebRTC Source](https://chromium.googlesource.com/external/webrtc.git).

This repository is used to compile [SendBirdWebRTC](https://github.com/sendbird/sendbird-webrtc-ios), and keep track of SendBird's changes.

In order to use this repository as a reflection of Google's Public WebRTC source, refer to this [medium guide](https://medium.com/@bilalbayasut/github-how-to-make-a-fork-of-public-repository-private-6ee8cacaf9d3) to fork public repository into this private repository.

---

**WebRTC is a free, open software project** that provides browsers and mobile
applications with Real-Time Communications (RTC) capabilities via simple APIs.
The WebRTC components have been optimized to best serve this purpose.
Expand Down
1 change: 1 addition & 0 deletions sdk/objc/api/peerconnection/RTCPeerConnection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ RTC_OBJC_EXPORT

typedef void (^RTCStatisticsCompletionHandler)(RTC_OBJC_TYPE(RTCStatisticsReport) *);

RTC_OBJC_EXPORT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예전에 이 flag 가 없어서 stat interface 사용을 못했던 건가 보군요 👍

@interface RTC_OBJC_TYPE (RTCPeerConnection)
(Stats)

Expand Down
6 changes: 3 additions & 3 deletions tools_webrtc/ios/build_ios_libs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
SDK_FRAMEWORK_NAME = 'WebRTC.framework'

DEFAULT_ARCHS = ENABLED_ARCHS = ['arm64', 'arm', 'x64', 'x86']
IOS_DEPLOYMENT_TARGET = '10.0'
LIBVPX_BUILD_VP9 = False
IOS_DEPLOYMENT_TARGET = '9.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target 은 왜 10에서 9로 변경되었나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저희 sdk 미니멈 버전이 9.0이라서 이것도 같이 맞췄습니당

LIBVPX_BUILD_VP9 = True
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 이제 VP9도 지원하나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 vp9은 전부터 지원했었습니다

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 vp9은 전부터 지원했었습니다

저희 iOS VP8이랑 H.264는 지원하는데 VP9 지원안하고 있지 않았었나요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전에도 키고 빌드했었는데, 없었나요....? 😨

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음 그러면 LIBVPX_BUILD_VP9 이거는 무엇인가요?? false 여도 VP9이 켜져있는건가요..???

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBVPX_BUILD_VP9 를 키면 VP9을 사용가능하게 하는거에용...뭐지..

Copy link

@x-0o0 x-0o0 May 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그렇군요. VP9가 이전엔 False였는데 지원했다구 해서 이해차 다시 여쭤보았습니다. 감사합니다. + Approve


sys.path.append(os.path.join(SCRIPT_DIR, '..', 'libs'))
from generate_licenses import LicenseBuilder
Expand All @@ -59,7 +59,7 @@ def _ParseArgs():
'If specified together with -c, deletes the dir.')
parser.add_argument('-r', '--revision', type=int, default=0,
help='Specifies a revision number to embed if building the framework.')
parser.add_argument('-e', '--bitcode', action='store_true', default=False,
parser.add_argument('-e', '--bitcode', action='store_true', default=True,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default 값의 false와 true 차이가 무엇인가요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저 플래그가 빌드할때 --bitcode를 입력하면 bitcode가 켜지고 입력안하면 디폴트로 bitcode를 키지 않는건데, 귀찮아서 --bitcode를 입력 안해도 비트코드가 켜지도록 바꿔놨습니다..ㅎ

help='Compile with bitcode.')
parser.add_argument('--verbose', action='store_true', default=False,
help='Debug logging.')
Expand Down