Fix crash on RTCPeerConnection.setRemote/LocalDescription #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved to #11 |
sf-jed-kyung
pushed a commit
that referenced
this pull request
Jul 7, 2025
This reverts commit c92fc76. Reason for revert: Gerritt submitted patch set #10 not #12 - this broke Original change's description: > Assign supported codecs per section, not globally. > > This uses the PayloadTypeSuggester for PT disambiguation, > ensuring that conficts are managed across the transport. > > Bug: webrtc:360058654 > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > Commit-Queue: Harald Alvestrand <[email protected]> > Reviewed-by: Evan Shrubsole <[email protected]> > Reviewed-by: Henrik Boström <[email protected]> > Cr-Commit-Position: refs/heads/main@{#44284} Bug: webrtc:360058654 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Bot-Commit: [email protected] <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Cr-Commit-Position: refs/heads/main@{#44285}
sf-jed-kyung
pushed a commit
that referenced
this pull request
Jul 7, 2025
This reverts commit 374b892. Reason for revert: Racing CLs sorted out Original change's description: > Revert "Assign supported codecs per section, not globally." > > This reverts commit c92fc76. > > Reason for revert: Gerritt submitted patch set #10 not #12 - this broke > > Original change's description: > > Assign supported codecs per section, not globally. > > > > This uses the PayloadTypeSuggester for PT disambiguation, > > ensuring that conficts are managed across the transport. > > > > Bug: webrtc:360058654 > > Change-Id: Ic8f0569d0d96d97c13765169903929ec8a110104 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383400 > > Commit-Queue: Harald Alvestrand <[email protected]> > > Reviewed-by: Evan Shrubsole <[email protected]> > > Reviewed-by: Henrik Boström <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#44284} > > Bug: webrtc:360058654 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I16d0d92fb9a1ecc65eda060f81d41faefcca1e4c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/384000 > Commit-Queue: Harald Alvestrand <[email protected]> > Reviewed-by: Danil Chapovalov <[email protected]> > Bot-Commit: [email protected] <[email protected]> > Reviewed-by: Mirko Bonadei <[email protected]> > Cr-Commit-Position: refs/heads/main@{#44285} Bug: webrtc:360058654 Change-Id: I80b59aab396abbc0afa60dab3516f2a22e822a5d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/383981 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Mirko Bonadei <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#44288}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.