Release 1.5.0 #16

mininny · 2022-04-20T15:53:50Z

No description provided.

The page was renamed in https://chromium-review.googlesource.com/c/chromium/src/+/3399246 Bug: None No-Try: true Change-Id: I7ddfb6c91b61ec071fbac95a30c56161119cc683 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248863 Auto-Submit: Danil Chapovalov <[email protected]> Reviewed-by: Artem Titov <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/main@{#35783}

Bug: webrtc:11933 Change-Id: I1700f4b75c3608985c9027f7d6a866fef97ec38f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246203 Reviewed-by: Per Kjellander <[email protected]> Commit-Queue: Björn Terelius <[email protected]> Cr-Commit-Position: refs/heads/main@{#35784}

And remove srte and crodbro since they are no longer active. Bug: none Change-Id: I218e078c2803770cce93e3acb53cebd4eb771171 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249082 Reviewed-by: Stefan Holmer <[email protected]> Commit-Queue: Per Kjellander <[email protected]> Cr-Commit-Position: refs/heads/main@{#35785}

Bug: webrtc:12701 Change-Id: Iab91f1e96715eed7f9ddcfe1ca55510a18c817eb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/224544 Reviewed-by: Artem Titov <[email protected]> Reviewed-by: Tomas Gunnarsson <[email protected]> Commit-Queue: Niels Moller <[email protected]> Cr-Commit-Position: refs/heads/main@{#35786}

This uses the local NTP clock for RTCP report block stats. This code exists in the version that Mozilla is shipping, with a review here https://phabricator.services.mozilla.com/D127709 . Bug: webrtc:13484 Change-Id: I2f46ec02acab0bbb09040778b05b248c2d815bd1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240142 Reviewed-by: Artem Titov <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#35787}

Change log: https://chromium.googlesource.com/chromium/src/+log/2962054fb0..2d23298755 Full diff: https://chromium.googlesource.com/chromium/src/+/2962054fb0..2d23298755 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/e622bde14a..e43e377270 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/906b90c327..949b669bd9 * src/buildtools/linux64: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * src/buildtools/mac: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * src/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/fd0ef6db30..579d5e5496 * src/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/295f84c04f..c8a5d430f2 * src/buildtools/win: git_revision:80a40b07305373617eba2d5878d353532af77da3..git_revision:0725d7827575b239594fbc8fd5192873a1d62f44 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/015f2c06aa..12759562b3 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/9ef62302b2..427e716890 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b4a203e0e4..0faf387dbb * src/third_party/androidx: cvnN-qE6n5AuBxEsTtzpda1KG8oF_QAjRf62bBkmqhkC..tD6afWCDy8ThEQz5eRDILYCo5Oa0bZ0-daMLVxkS_7QC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8bc3659ded..d90eeee993 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b8f1ca3058..c5f0cbb865 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/0b635b1eb2..02fa26f4cd * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/2ddfdf819d..3d81736c97 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/bda2a707d5..d7b55ea623 * src/third_party/turbine: 8Wzi8_CpwqQkJeczCQavMiPI6wJMCSLh_4jpRwUIlSkC..RkSl7-UvBXltU55m5zi387oPTAJqTj3Oz6nIpQkOI4wC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/7f40597977..cf9c29a689 * src/tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 * src/tools/luci-go: git_revision:5b02a4aaeb5fd78d6fe41d6d54d1cb58da17f192..git_revision:09f8b3edbbf18dc63d0d5aa7722ae7acc20b11b4 DEPS diff: https://chromium.googlesource.com/chromium/src/+/2962054fb0..2d23298755/DEPS No update to Clang. BUG=None Change-Id: Ibe65423698c7314d33fb6f239b2fba45882bab3f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249160 Bot-Commit: Autoroller <[email protected]> Commit-Queue: Autoroller <[email protected]> Cr-Commit-Position: refs/heads/main@{#35788}

Bug: None Change-Id: Ifcb2618ad33f459b85bc732b043965b1ddbd3289 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249321 Bot-Commit: [email protected] <[email protected]> Commit-Queue: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#35792}

This patch adds a method for setting the keyframe request method to VideoReceiveStream. This code exists in the version that Mozilla is shipping, with a review https://phabricator.services.mozilla.com/D105773 . Bug: webrtc:13486 Change-Id: I7cc19dec95d6523368d73395319854bd8c2166f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/240140 Reviewed-by: Stefan Holmer <[email protected]> Commit-Queue: Stefan Holmer <[email protected]> Cr-Commit-Position: refs/heads/main@{#35793}

Avoid implicit conversion from rtc::scoped_refptr to raw pointer, when calling the MethodCall and ConstMethodCall constructors. Fixed by defining a private accessor T* c() which always returns a raw pointer, with different implementation for BEGIN_PROXY_MAP and BEGIN_OWNED_PROXY_MAP. Avoid using the same name for macro argument and function argument within the macro definition, like `c` in: ``` #define PRIMARY_PROXY_MAP_BOILERPLATE(c) \ protected: \ c##ProxyWithInternal(rtc::Thread* primary_thread, INTERNAL_CLASS* c) \ : primary_thread_(primary_thread), c_(c) {} \ ``` Fixed by using `class_name` as the macro argument throughout. Bug: webrtc:13464 Change-Id: I9faf095b004afd5225f5ec09fb782ef4b5c9dc5d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249089 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Niels Moller <[email protected]> Cr-Commit-Position: refs/heads/main@{#35794}

This adds a field trial to change the pacing rate to pace at a rate relative to max(bwe ,lower link capacity) Bug: none Change-Id: Ibe9ef3e08eb422e9abff6488780e82188958eeeb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248865 Reviewed-by: Björn Terelius <[email protected]> Commit-Queue: Per Kjellander <[email protected]> Cr-Commit-Position: refs/heads/main@{#35795}

This test was failing in 2017 and was disabled then. https://crbug.com/webrtc/8642 It being removed because it doesn't really help to have failing tests as examples. Bug: webrtc:13595 Change-Id: Ifa5d9b1068a65e699e0db1f59b2b227654c67637 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/247903 Reviewed-by: Mirko Bonadei <[email protected]> Reviewed-by: Christoffer Jansson <[email protected]> Reviewed-by: Xavier Lepaul‎ <[email protected]> Commit-Queue: Xavier Lepaul‎ <[email protected]> Cr-Commit-Position: refs/heads/main@{#35796}

Some of the state that's managed in VideoStreamEncoder, is updated and accessed on the encoder queue, but a method that's used for testing only (GetAdaptationResources()), represents a race between PostTask operations that update state and checking for said state on the worker thread. This CL removes Wait() operations related to adaptation resources from the common path and puts one in the test path instead. Bug: webrtc:13612 Change-Id: Ie3e018e815e24951bc0634ed70de17eaf336a508 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249220 Reviewed-by: Henrik Boström <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#35797}

Move deletion of channel objects over to the RtpTransceiver instead of having it done by SdpOfferAnswer. The deletion is now also done via PostTask rather than Invoke. Bug: webrtc:11992, webrtc:13540 Change-Id: I5aff14956d5e572ca8816bbfef8739bb609b4484 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/248170 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#35798}

This CL adds a SequenceChecker, receive_11993_checker_, specifically for variables that need to move to the network thread. Once migrated, the checker will be replaced with a check for the network thread. In the meantime, the checker will match with one of worker [x]or network threads. As a first step, this checker is used to isolate access to `receive_rtp_config_` which is used from object factory paths (Create/ Destroy routines) as well as paths that handle network packets. Bug: webrtc:11993 Change-Id: Ia58423583cf99492018f218eb1640535e3919193 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249080 Reviewed-by: Niels Moller <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#35800}

Just applied a short sed script. See bug description for the motiviation for this change. This is the command that was used to generate the changes: $ find . -type f $ -iname '*.cc' -o -iname '*.h' $ -print0 | \ xargs -0 sed -i -e 's/(const override)/(const, override)/' Bug: webrtc:13090 Change-Id: Iec7d280f9d55263a972dbb3bd644ebfcd2eb38cf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249088 Reviewed-by: Mirko Bonadei <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Ali Tofigh <[email protected]> Cr-Commit-Position: refs/heads/main@{#35801}

This is a safe cleanup change since top-level const applied to parameters in function declarations (that are not also definitions) are ignored by the compiler. Hence, such changes do not change the type of the declared functions and are simply no-ops. Bug: webrtc:13610 Change-Id: Ibafb92c45119a6d8bdb6f9109aa8dad6385163a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249086 Reviewed-by: Niels Moller <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Ali Tofigh <[email protected]> Cr-Commit-Position: refs/heads/main@{#35802}

This is a delegate that is used by video_receive_stream2 to handle frame buffer tasks like threading, and stats. This will be used in a follow up to use FrameBuffer3 as a strategy selected by field trial. Unit-tests will be used in follow-up CLs containing Frame Buffer 3, and are expected to work with both Frame buffer proxy versions. Change-Id: I524279343d60a348d044d9085d618f12d7bf3a23 Bug: webrtc:13343 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/241605 Reviewed-by: Ilya Nikolaevskiy <[email protected]> Reviewed-by: Philip Eliasson <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Commit-Position: refs/heads/main@{#35803}

This makes fuzzer test cases fail if there's an assert failure in the helper functions called by the test. Bug: None Change-Id: Ic187d72b8d4e016659a68a7bdcaadb78ab2aab05 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/246400 Reviewed-by: Danil Chapovalov <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#35804}

Bug: webrtc:13555, webrtc:13082 Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260 Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Artem Titov <[email protected]> Commit-Queue: (Daniel.L) Byoungchan Lee <[email protected]> Cr-Commit-Position: refs/heads/main@{#35805}

This std::map was used to look up audio streams from ssrcs when creating/destroying and/or modifying streams. Those operations aren't frequent enough to justify having a separate lookup map. Removing the variable, simplifies the thread ownership work a bit. Bug: webrtc:11993 Change-Id: I94f9f2f56c138051a8b9c5f6a6d7cae3a4e78b48 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249091 Reviewed-by: Niels Moller <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#35806}

This reverts commit 5f0eb93. Reason for revert: Breaks downstream project. I'm going to fix that one and create a reland of this CL after. Original change's description: > Remove RTC_DISALLOW_COPY_AND_ASSIGN usages completely > > Bug: webrtc:13555, webrtc:13082 > Change-Id: Iff2cda6f516739419e97e975e03f77a98f74be03 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249260 > Reviewed-by: Harald Alvestrand <[email protected]> > Reviewed-by: Artem Titov <[email protected]> > Commit-Queue: (Daniel.L) Byoungchan Lee <[email protected]> > Cr-Commit-Position: refs/heads/main@{#35805} [email protected],[email protected],[email protected],[email protected] Change-Id: I33d497f1132adfe6d151023195a388d9b7d548f9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:13555, webrtc:13082 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249364 Reviewed-by: Artem Titov <[email protected]> Owners-Override: Artem Titov <[email protected]> Reviewed-by: Andrey Logvin <[email protected]> Reviewed-by: Björn Terelius <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/main@{#35807}

This is a test-only class that today has high precision for its frames. We intend to make the default task queue precision lower, so high precision use cases have to opt-in to kHigh if they want to continue to use high precision. Bug: webrtc:13604 Change-Id: I25babec2a64d91d45548ad017200b806a60efe11 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249362 Reviewed-by: Erik Språng <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#35808}

Context: The timer precision of PostDelayedTask() is about to be lowered to include up to 17 ms leeway. In order not to break use cases that require high precision timers, PostDelayedHighPrecisionTask() will continue to have the same precision that PostDelayedTask() has today. webrtc::TaskQueueBase has an enum (kLow, kHigh) to decide which precision to use when calling PostDelayedTaskWithPrecision(). See go/postdelayedtask-precision-in-webrtc for motivation and a table of delayed task use cases in WebRTC that are "high" or "low" precision. Most timers in DCSCTP are believed to only be needing low precision (see table), but the delayed_ack_timer_ of DataTracker[1] is an example of a use case that is likely to break if the timer precision is lowered (if ACK is sent too late, retransmissions may occur). So this is considered a high precision use case. This CL makes it possible to specify the precision of dcsctp::Timer. In a follow-up CL we will update delayed_ack_timer_ to kHigh precision. [1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/net/dcsctp/rx/data_tracker.cc;l=340 Bug: webrtc:13604 Change-Id: I8eec5ce37044096978b5dd1985fbb00bc0d8fb7e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249081 Reviewed-by: Victor Boivie <[email protected]> Reviewed-by: Tomas Gunnarsson <[email protected]> Commit-Queue: Henrik Boström <[email protected]> Cr-Commit-Position: refs/heads/main@{#35809}

Bug: None Change-Id: I49e1a2808f144c5dfbfa513ae3cba00cd5a8dcd4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/249540 Bot-Commit: [email protected] <[email protected]> Commit-Queue: [email protected] <[email protected]> Cr-Commit-Position: refs/heads/main@{#35811}

Bug: chromium:1280852 Change-Id: I7f6c5de86ceee01156743c0389c59f875e53bb5f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251580 Reviewed-by: Minyue Li <[email protected]> Commit-Queue: Henrik Lundin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36005}

Bug: b/213863770 Change-Id: Idcf37150e769db18d4a12baa1057840d521b8e1f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251761 Reviewed-by: Ilya Nikolaevskiy <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/main@{#36006}

Bug: none Change-Id: Ie42461dd06b1764c99308393477921ea25319ab4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251687 Reviewed-by: Erik Språng <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36007}

This has mostly seemed to work fine until now; but there's a collision happening in chromium where if the source is being shown in the Window Picker it collides with the (also null) Dialog ID and is ignored. While we could patch that code to not count Null as a collision, there's the potential for other (future) code to simply ignore a capture source that it thinks is Null. Fixed: chromium:1295375 Change-Id: I4356084f0af97f4d56632938b0d9a24d327f7107 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251500 Reviewed-by: Mark Foltz <[email protected]> Auto-Submit: Alexander Cooper <[email protected]> Commit-Queue: Alexander Cooper <[email protected]> Cr-Commit-Position: refs/heads/main@{#36008}

Bug: webrtc:13680 Change-Id: I0faf0d03541fce2b93c03857e01e85588389ccd1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251720 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36009}

Bug: webrtc:13673, webrtc:13681 Change-Id: I06810338bf5e44665e4d005d35636e9a98b1bd0b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251684 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36010}

Current implementation has mouse cursor as part of the screen itself which means that everytime a cursor changes location, we have to update whole screen content, which brings unnecessary load overhead. Using our own mouse cursor monitor implementation allows us to track only mouse cursor changes and update them separately for much better performance. Bug: webrtc:13429 Change-Id: I224e9145f0bc7e45eafe4490de160f2ad4c8b545 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/244507 Reviewed-by: Tomas Gunnarsson <[email protected]> Reviewed-by: Mark Foltz <[email protected]> Commit-Queue: Mark Foltz <[email protected]> Cr-Commit-Position: refs/heads/main@{#36011}

This reverts commit 09aaf6f. Reason for revert: downstream fixed (see https://chromium-review.googlesource.com/c/chromium/src/+/3461371) Original change's description: > Revert "Reland "Remove unused APM voice activity detection sub-module"" > > This reverts commit 54d1344. > > Reason for revert: Breaks chromium roll, see > https://ci.chromium.org/ui/p/chromium/builders/try/linux_chromium_tsan_rel_ng/1080583/overview > > https://chromium-review.googlesource.com/c/chromium/src/+/3461512 > > Original change's description: > > Reland "Remove unused APM voice activity detection sub-module" > > > > This reverts commit a751f16. > > > > Reason for revert: dependency in a downstream project removed > > > > Original change's description: > > > Revert "Remove unused APM voice activity detection sub-module" > > > > > > This reverts commit b4e06d0. > > > > > > Reason for revert: breaking downstream projects > > > > > > Original change's description: > > > > Remove unused APM voice activity detection sub-module > > > > > > > > API changes: > > > > - webrtc::AudioProcessing::Config::VoiceDetection removed > > > > - webrtc::AudioProcessingStats::voice_detected deprecated > > > > - cricket::AudioOptions::typing_detection deprecated > > > > - webrtc::StatsReport::StatsValueName:: > > > > kStatsValueNameTypingNoiseState deprecated > > > > > > > > PSA: https://groups.google.com/g/discuss-webrtc/c/7X6uwmJarE0 > > > > > > > > Bug: webrtc:11226,webrtc:11292 > > > > Change-Id: I8d008b56708cf62961b9857ec052b59fda3b41bf > > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/250666 > > > > Reviewed-by: Harald Alvestrand <[email protected]> > > > > Reviewed-by: Gustaf Ullberg <[email protected]> > > > > Reviewed-by: Sam Zackrisson <[email protected]> > > > > Reviewed-by: Björn Terelius <[email protected]> > > > > Commit-Queue: Alessio Bazzica <[email protected]> > > > > Cr-Commit-Position: refs/heads/main@{#35975} > > > > > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > > > > > Change-Id: Iee01fdb874b4e0331277f3ffe60dacaabc3859a2 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: webrtc:11226,webrtc:11292 > > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251600 > > > Reviewed-by: Harald Alvestrand <[email protected]> > > > Reviewed-by: Gustaf Ullberg <[email protected]> > > > Commit-Queue: Mirko Bonadei <[email protected]> > > > Cr-Commit-Position: refs/heads/main@{#35977} > > > > # Not skipping CQ checks because this is a reland. > > > > Bug: webrtc:11226,webrtc:11292 > > Change-Id: I2fcbc5fdade16bfe6a0f0a02841a33a598d4f2ad > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251660 > > Reviewed-by: Alessio Bazzica <[email protected]> > > Reviewed-by: Harald Alvestrand <[email protected]> > > Commit-Queue: Alessio Bazzica <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#35984} > > [email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected] > > Change-Id: Ib308a3af2dcce85a0074ef5a4680ccec3f82712f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:11226,webrtc:11292 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251688 > Reviewed-by: Henrik Boström <[email protected]> > Bot-Commit: [email protected] <[email protected]> > Auto-Submit: Henrik Boström <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Commit-Queue: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#35990} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: webrtc:11226,webrtc:11292 Change-Id: Idfda6a517027ad323caf44c526a88468e5b52b65 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251762 Reviewed-by: Alessio Bazzica <[email protected]> Bot-Commit: [email protected] <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Reviewed-by: Sam Zackrisson <[email protected]> Commit-Queue: Alessio Bazzica <[email protected]> Cr-Commit-Position: refs/heads/main@{#36012}

Bug: none Change-Id: I3e2c503efc7a85a3daaa40cd8118c1b02d3b81cf Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251680 Reviewed-by: Stefan Holmer <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36013}

Bug: none Change-Id: Ic3f478c5cde12e8a4d1d121749c0414b254a3ea3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251695 Reviewed-by: Stefan Holmer <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36014}

Bug: none Change-Id: I2c6943b91a6d58b884270a029bcf210e4d5c7a91 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251782 Reviewed-by: Rasmus Brandt <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36015}

allow absl::Cleanup for such purpose Bug: webrtc:13674 Change-Id: I7434c7a48f1135bf4bf14b66996fbff1a7016c74 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251781 Reviewed-by: Tomas Gunnarsson <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Reviewed-by: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/main@{#36016}

Bug: b/213863770 Change-Id: I69c0a9983831b7d59e24dc800a5f0d198cb40747 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251820 Reviewed-by: Mirko Bonadei <[email protected]> Reviewed-by: Ilya Nikolaevskiy <[email protected]> Commit-Queue: Artem Titov <[email protected]> Cr-Commit-Position: refs/heads/main@{#36017}

To disable dcSCTP and fallback to usrsctp, you can use the field trial WebRTC-DataChannel-Dcsctp/Disabled/ Bug: chromium:1243702 Change-Id: Ia90b796562245558a61481317bcded437400b045 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251800 Auto-Submit: Florent Castelli <[email protected]> Commit-Queue: Florent Castelli <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#36018}

Bug: none Change-Id: I8bd049cb8e8c958e59bf90a61198b7933eb5d40f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251692 Reviewed-by: Stefan Holmer <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36019}

Bug: None Change-Id: Id94771626ef723212e4d92d9093af3ec9e647990 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251780 Auto-Submit: Danil Chapovalov <[email protected]> Reviewed-by: Erik Språng <[email protected]> Commit-Queue: Danil Chapovalov <[email protected]> Cr-Commit-Position: refs/heads/main@{#36020}

Minor related updates to AudioTrack and VideoTrack's sequence checkers. There's more that can be done (or arguably needs to), but this is a start. Bug: none Change-Id: I3ccf8eb9bbb6bef62b83248a23a68871b9fcd9e1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251843 Reviewed-by: Niels Moller <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36021}

This reverts commit 035e97a. Reason for revert: Breaks downstream projects. Original change's description: > Make dcSCTP the default SCTP implementation > > To disable dcSCTP and fallback to usrsctp, you can use the field trial > WebRTC-DataChannel-Dcsctp/Disabled/ > > Bug: chromium:1243702 > Change-Id: Ia90b796562245558a61481317bcded437400b045 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251800 > Auto-Submit: Florent Castelli <[email protected]> > Commit-Queue: Florent Castelli <[email protected]> > Reviewed-by: Harald Alvestrand <[email protected]> > Commit-Queue: Harald Alvestrand <[email protected]> > Cr-Commit-Position: refs/heads/main@{#36018} [email protected],[email protected],[email protected] Change-Id: Id4767920abc9a4d934b5d9bb49ea0b2178df950b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1243702 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251862 Bot-Commit: [email protected] <[email protected]> Reviewed-by: Mirko Bonadei <[email protected]> Owners-Override: Mirko Bonadei <[email protected]> Commit-Queue: Christoffer Jansson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36022}

These have been depreated since November 2021. Bug: webrtc:13362 Change-Id: Ifc1b984ab54faefc974006f37f909e6927aed056 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251760 Reviewed-by: Mirko Bonadei <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Commit-Position: refs/heads/main@{#36023}

Bug: none Change-Id: If36ee02ee762718b1c1b6f84cd22cb866ba0d51b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251863 Reviewed-by: Erik Språng <[email protected]> Commit-Queue: Sergey Silkin <[email protected]> Cr-Commit-Position: refs/heads/main@{#36024}

This CL contains a part of a previously reviewed, landed, reverted, relanded and re-reverted CL: https://webrtc-review.googlesource.com/c/src/+/250180 Bug: webrtc:13540 Change-Id: Id6df8da5ff61e3ec90d0b3f3d828e8f670d4931b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251860 Reviewed-by: Harald Alvestrand <[email protected]> Auto-Submit: Tomas Gunnarsson <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36025}

This skips going through the proxy and potentially hide a thread hop should a regression occur. This CL contains a part of a previously reviewed, landed, reverted, relanded and re-reverted CL: https://webrtc-review.googlesource.com/c/src/+/250180 Bug: webrtc:13540 Change-Id: If098f5c04a263547fb53f44e9f9738b8e941a294 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251861 Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Tomas Gunnarsson <[email protected]> Cr-Commit-Position: refs/heads/main@{#36026}

To disable dcSCTP and fallback to usrsctp, you can use the field trial WebRTC-DataChannel-Dcsctp/Disabled/ Also remove a hidden no-break space in dcSCTP logging causing issues in some log parsing. (cherry picked from commit 29ff3ef) Bug: chromium:1243702 Change-Id: I46136a8913a6d803a3c63c710f3ed29523e4d773 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/251867 Auto-Submit: Florent Castelli <[email protected]> Reviewed-by: Victor Boivie <[email protected]> Reviewed-by: Harald Alvestrand <[email protected]> Commit-Queue: Harald Alvestrand <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#36027} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252481 Reviewed-by: Victor Boivie <[email protected]> Commit-Queue: Florent Castelli <[email protected]> Cr-Commit-Position: refs/branch-heads/4896@{#1} Cr-Branched-From: 962bf18-refs/heads/main@{#36026}

…eBuffer3 R=[email protected] (cherry picked from commit d4ff12f) Change-Id: I9a961417f86fd1f968a42730249d479e3ebd4784 Bug: webrtc:13343, webrtc:13755, chromium:1302207 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/252583 Reviewed-by: Ilya Nikolaevskiy <[email protected]> Reviewed-by: Philip Eliasson <[email protected]> Commit-Queue: Evan Shrubsole <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#36100} No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/253940 Cr-Commit-Position: refs/branch-heads/4896@{#2} Cr-Branched-From: 962bf18-refs/heads/main@{#36026}

* 4896: (1565 commits) [Merge M100] Increment frame count once for duplicate frame with FrameBuffer3 [Merge to M100] Reland: Make dcSCTP the default SCTP implementation Use internal() in VideoTrack when invoking the source. Move VideoTrackSourceProxy creation into VideoTrack. Report encode/decode latency Delete INFO/WARNING/LERROR log levels Revert "Make dcSCTP the default SCTP implementation" Add several thread checks to RtpSender classes. in RTPSender disallow enabling misconfigured rtx Disable periodic keyframes Make dcSCTP the default SCTP implementation [PCLF] Remove deprecated APIs Fix fd leak in ifaddrs_android.cc Return name of underlaying HW codec Use isHardwareAccelerated on Q+ Add bitrate adaptation tests Reland "Reland "Remove unused APM voice activity detection sub-module"" Implement MouseCursorMonitorPipeWire to track cursor changes separately Move VideoTrack's content_hint property to the signaling thread. Move enabled() methods for VideoTrack over to signaling ... # Conflicts: # media/engine/simulcast_encoder_adapter.cc # media/engine/simulcast_encoder_adapter.h # modules/video_coding/frame_buffer2.cc # modules/video_coding/timing.cc # pc/jsep_transport_controller.cc # sdk/objc/api/peerconnection/RTCPeerConnection.mm # sdk/objc/native/api/audio_device_module.h # sdk/objc/native/api/audio_device_module.mm # sdk/objc/native/src/audio/audio_device_module_ios.mm # sdk/objc/unittests/RTCPeerConnectionTest.mm # tools_webrtc/ios/build_ios_libs.py # video/video_send_stream_tests.cc # video/video_stream_encoder.cc

Feature/update to m100

DanilChapovalov and others added 30 commits January 25, 2022 11:07

Henrik Lundin and others added 28 commits February 15, 2022 15:59

Merge pull request #15 from sendbird/feature/update-to-m100

981fdbc

Feature/update to m100

Bump up version to 1.5.0

f77030a

Fix build error

9697715

mininny merged commit feec28f into master Apr 20, 2022

mininny deleted the release/1.5.0 branch April 20, 2022 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release 1.5.0 #16

Release 1.5.0 #16

Uh oh!

mininny commented Apr 20, 2022

Uh oh!

Uh oh!

Release 1.5.0 #16

Release 1.5.0 #16

Uh oh!

Conversation

mininny commented Apr 20, 2022

Uh oh!

Uh oh!