Update java http client dependency to 4.0.0 issue #155

[diegoc-am]

No description provided.

[diegoc-am]

The tests were failing on my end, even in master, didn't know how to fix them. The code looks good in my opinion @thinkingserious

[thinkingserious]

@belfazt,

Have you installed Prism for you local tests?

[diegoc-am]

@thinkingserious,

Awesome, that solved the issue, now, how do I get travis to work? :P

Gradle Worker 1 executing tests. Gradle Worker 1 finished executing tests. Process 'Gradle Worker 1' finished with exit value 0 (state: SUCCEEDED) Finished generating test XML results (0.023 secs) Generating HTML test report... Finished generating test html results (0.037 secs) :test (Thread[main,5,main]) completed. Took 2 mins 18.607 secs.

[thinkingserious]

@belfazt,

Don't worry about the Travis builds, this issue will resolve this problem.

Thank you for verifying!

[ARaqeeb]

Kindly try to merge this as soon as possible! Based off Git Issue.

Please try to use the latest Http Client. Thanks a bunch!

[SendGridDX]

Hello @belfazt,

This issue has finally risen to the top of our queue!

The java-http-client is now at v4.1.0. Could you please update your PR?

Thanks!

Elmer

[diegoc-am]

Updating PR

[diegoc-am]

Starting process 'Gradle Worker 1'. Working directory: /Users/andres/hacktoberfest/sendgrid-java Command: /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/bin/java -Djava.security.manager=jarjar.org.gradle.process.internal.child.BootstrapSecurityManager -Dfile.encoding=UTF-8 -ea -cp /Users/andres/.gradle/caches/1.8/workerMain/gradle-worker.jar jarjar.org.gradle.process.internal.launcher.GradleWorkerMain
An attempt to initialize for well behaving parent process finished.
Successfully started process 'Gradle Worker 1'
Gradle Worker 1 executing tests.
Gradle Worker 1 finished executing tests.
Process 'Gradle Worker 1' finished with exit value 0 (state: SUCCEEDED)
Finished generating test XML results (0.018 secs)
Generating HTML test report...
Finished generating test html results (0.027 secs)
:test (Thread[main,5,main]) completed. Took 21.741 secs.

BUILD SUCCESSFUL

[SendGridDX]

All committers have signed the CLA.

[diegoc-am]

I think I've already signed a CLA agreement

[thinkingserious]

Hello @belfazt,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

[diegoc-am]

More swag! Thanks :)

…

On May 18, 2017 8:02 PM, "Elmer Thomas" ***@***.***> wrote: Hello @belfazt <https://github.com/belfazt>, Thanks again for the PR! We want to show our appreciation by sending you some swag. Could you please fill out this form <https://dx.sendgrid.com/swag> so we can send it to you? Thanks! Team SendGrid DX — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#162 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEBStPCDRI2NLGHHrzZyyxpY6tZKSteOks5r7OoPgaJpZM4KbrHB> .

[thinkingserious]

Well deserved!

[YEMEAC]

hi, I'm getting java.lang.NoClassDefFoundError: com/sendgrid/SendGridResponseHandler but the mail is being sent.
After read the different comments can't see exactly whats the change that needs to be done to stop having this problem.
some help please? 🙏

[thinkingserious]

Hello @YeisonMelo,

Could you please provide the following details:

1. What version of the SDK are you using?
2. How did you install it?
3. Can you share the code that is causing the issue?

Thanks!

With Best Regards,

Elmer

[YEMEAC]

Hi,
<dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpcore</artifactId> <version>4.4.4</version> </dependency>
<dependency> <groupId>org.apache.httpcomponents</groupId> <artifactId>httpclient</artifactId> <version>4.5.2</version> </dependency>
<dependency> <groupId>com.sendgrid</groupId> <artifactId>sendgrid-java</artifactId> <version>4.0.1</version> </dependency>

Response response = sendGrid.api(request); is the line that gives me the error. The application doesn't crash and I get the email but the NoClassDefFoundError appears every time.

Listener method 'handleSendNotifierReport' threw exception; nested exception is java.lang.NoClassDefFoundError: org/apache/http/impl/client/AbstractResponseHandler

[thinkingserious]

Hi @YeisonMelo,

I think there is trouble with redundant dependencies.

What happens if you remove all the dependencies to httpcomponents?

e.g. just have:

<dependency>
  <groupId>com.sendgrid</groupId>
  <artifactId>sendgrid-java</artifactId>
  <version>4.0.1</version>
</dependency>

[YEMEAC]

hi thank you for helping. Only keep the sengrid-java dependency was one of my first tries but after doing it the problem remained with the same behaviour. I have simplified my code to be able to use the version 2.2.2 and it works but from the version 3.0.0 the problem appears. I need to use the version 3.0.0 or higher with my project.

[thinkingserious]

Do you have any other dependencies that use the apache dependencies? I've seen cases where duplicate conflicting versions of apache were installed because of that.

[YEMEAC]

looks like that can be the problem is a very big project so I isolated the module that uses sendgrid an have been able to send the email without the error.

[YEMEAC]

is there any way to use send grid without the httpclient dependencies? I found dependencies in the project with different versions that the one send grid includes(4.5.2) but I can't remove them or upgrade them to 4.5.2 without making other modules fail.

[thinkingserious]

Hello @YeisonMelo,

I'm not sure how to solve your specific issue, but it seems these threads might point you in the right direction:

https://stackoverflow.com/questions/19659425/conflicting-library-version-in-a-java-maven-project
https://stackoverflow.com/questions/7175398/maven-dependency-resolution-conflicted
http://techidiocy.com/maven-dependency-version-conflict-problem-and-resolution/
https://www.ricston.com/blog/solving-dependency-conflicts-maven/

With Best Regards,

Elmer

[YEMEAC]

I solve the problem thank you! 🎉 here my thoughts. The initial version 3.2.0 was failing for some problem in the jar file, it was looking for the class SendGridResponseHandler but wasn't able to find it during running time even when it was there, I checked the jar by myself. I read in other blogs that the jar 3.2.0 had some problem...

Then I update to the last version 4.0.1, then my problem was with dependencies since I was importing versions of httpclient and httpcore that were not compatible with send grid 4.0.1 so I made sure sendgrid was the first one importing the httpclient and httcore dependencies placing the sendgrid dependency at the begging of the pom file, the links @thinkingserious shared helped me to understand that this was happening.

[thinkingserious]

That's awesome, thanks for sharing your results @YeisonMelo!