Encapsulate unsafe in _cssparser_internal_to_lowercase macro
#335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows it to be used in codebases with #[forbid(unsafe)]. Also document the safety invariant for the unsafe block
|
Oh, good idea! This is now possible with const generics @bors-servo r+ |
|
📌 Commit 39ea1b0 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
_cssparser_internal_to_lowercasemacro to be used in crates that set#[forbid(unsafe)].Changes made
unsafeblock in the_cssparser_internal_to_lowercasemacro in an#[inline(always)]function.Context