Skip to content

Conversation

moz-gfx
Copy link

@moz-gfx moz-gfx commented Mar 25, 2022

No description provided.

…-reviewers,nical

When the max surface size is exceeded, the raster spatial node
for a given surface is adjusted in `get_surface_rects`. However
a locally cached variable of the old raster spatial node index
was being used as a parameter when creating the render task.

Instead, only retrieve the raster spatial node after the call to
`get_surface_rects`, ensuring that it gets the updated value.

Also add support to wrench reftests to set the maximum surface
size, so that we can exercise this code path in reftests.

Differential Revision: https://phabricator.services.mozilla.com/D142015

[ghsync] From https://hg.mozilla.org/mozilla-central/rev/3b9aede36b948000eee4351484b8bcb88f1e83e0
@moz-gfx
Copy link
Author

moz-gfx commented Mar 25, 2022

@bors-servo r=auto

@bors-servo
Copy link
Contributor

📌 Commit afcf7bc has been approved by auto

@bors-servo
Copy link
Contributor

⌛ Testing commit afcf7bc with merge da1df33...

@bors-servo
Copy link
Contributor

☀️ Test successful - status-taskcluster
Approved by: auto
Pushing da1df33 to master...

@bors-servo bors-servo merged commit da1df33 into servo:master Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants