fix: Ignore keywords for uppercase=True #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wugeer
force-pushed
the
fix_issue_33
branch
from
ea120a7 to
85eb6d6
Compare
wugeer
force-pushed
the
fix_issue_33
branch
from
85eb6d6 to
094f4d7
Compare
shssoichiro
reviewed
Sep 17, 2024
more rustc! Co-authored-by: Josh Holmer <[email protected]>
BilelGho
reviewed
Oct 5, 2024
| /// Formats whitespace in a SQL string to make it easier to read. | ||
| /// Optionally replaces parameter placeholders with `params`. | ||
| pub fn format(query: &str, params: &QueryParams, options: FormatOptions) -> String { | ||
| pub fn format(query: &str, params: &QueryParams, options: &FormatOptions) -> String { |
There was a problem hiding this comment.
This is a breaking change for libraries like sqlx
There was a problem hiding this comment.
The fact that a field was added to FormatOptions and Copy was removed from it makes it difficult to revert the breaking change without reverting this entire PR. I think I will move forward with releasing the new version as semver breaking instead. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #33