Skip to content

Do not track binlogFilename/binlogPosition when GtidSet is set #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shyiko opened this issue Jan 11, 2019 · 2 comments
Closed

Do not track binlogFilename/binlogPosition when GtidSet is set #254

shyiko opened this issue Jan 11, 2019 · 2 comments

Comments

@shyiko
Copy link
Owner

shyiko commented Jan 11, 2019

#250 (comment)

NOTE: having binlogFilename/binlogPosition avoids scanning unnecessary logs so check what are the options before blindly disabling binlogFilename/binlogPosition tracking.
@shyiko shyiko mentioned this issue Jan 11, 2019
Merged
@osheroff
Copy link
Collaborator

hey @shyiko this is actually pretty nasty / dangerous; see

zendesk/maxwell#1129 (comment)
and
zendesk/maxwell#1192

turns out that unless we jump through a lot of hoops to reconnect in GTID land, things go quite wrong.

shyiko pushed a commit that referenced this issue Jan 22, 2019
Added BinaryLogClient::useBinlogFilenamePositionInGtidMode to control…
fe6691c 
… DumpBinaryLogGtidCommand (#254)
@shyiko
Copy link
Owner Author

shyiko commented Jan 22, 2019

Fixed in 0.18.0.

@shyiko shyiko closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osheroff @shyiko