Skip to content

Conversation

@vanling
Copy link
Contributor

@vanling vanling commented Feb 13, 2023

Closes #236 .

Checklist:

  • issue number linked above after pound (#)
  • manually checked my feature + lint + types
  • testing not applicable
  • screenshot not applicable

@vanling
Copy link
Contributor Author

vanling commented Feb 13, 2023

I moved the code inside nuxtApp.hook('app:mounted', () => {}) i could've also added if(process.client) but this does the same I guess.

@vanling vanling changed the title Make sure SessionRefreshPeriodically is run on client only Fix: Make sure SessionRefreshPeriodically is run on client only Feb 13, 2023
Copy link
Contributor

@BracketJohn BracketJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch + fix, thanks @vanling ❤️

@BracketJohn BracketJohn merged commit 4dbbcdc into sidebase:main Feb 15, 2023
@ThomasKoscheck
Copy link

Very nice, when will this fix become available through npm?
Would be very nice to have this as soon as possible!

@zoey-kaiser zoey-kaiser mentioned this pull request Feb 20, 2023
@zoey-kaiser
Copy link
Member

Very nice, when will this fix become available through npm?
Would be very nice to have this as soon as possible!

I just released Version 0.4.2 of nuxt-auth! See the release here: https://github.com/sidebase/nuxt-auth/releases/tag/0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enableSessionRefreshPeriodically: throws errors on the server

4 participants