-
-
Notifications
You must be signed in to change notification settings - Fork 186
chore: updated ESLint and general housekeeping #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| // At this point the request succeeded (i.e., it went through) | ||
| const error = new URL(data.url).searchParams.get('error') | ||
| // eslint-disable-next-line ts/no-use-before-define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: For some issues I decided to disable the eslint rule for now. The biggest Issue that I did this for was when functions were used before they were defined.
This change would require making them all top-level functions (which I think is a good idea) but sadly we have some helpers (e.g. makeCWN: Make a call with Nuxt function) that makes this a bit more tricky. In addition to this, we also type a lot of functions with their params and returns, which was also tricky to continue using this, while making them top-level functions.
@phoenix-ru, feel free to fix these issues if you would like in this PR or a follow-up PR. However, I think its good to avoid big code changes here and only address minimal changes to avoid any breaking changes!
|
We also disabled all Nuxt Auto-imports. This was done a long time ago, I was wondering if we could maybe re-enable them, as this could reduce the amount of imports (+ incorrect typings) and also make the playgrounds act more like an actual Nuxt App would! |
β¦nto chore/update-eslint
β¦nto chore/update-eslint
π Linked issue
Closes N/A
β Type of change
π Description
This PR:
.vscodefolder for extensions and settingsπ Checklist