#6008 Fixed placement errors for get started banner and first conversation #6009
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armartinez
changed the title
armartinez
changed the title
armartinez
changed the title
ImAwsumm
approved these changes
Mar 26, 2025
Signal/src/ViewControllers/HomeView/Chat List/ChatListViewController.swift
Outdated
Show resolved
Hide resolved
…roller.swift Co-authored-by: Ankush <[email protected]>
ankushkushwaha
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
This fixes issue #6008 for the placement of the get started banner and first conversation cue. The get started banner was inheriting the margins from the chat list view, which after opening a conversation gets modified by the navigation, for instance when showing the search bar. This change just breaks that link and passes a fixed value for the leading a trailing margins which are changed by matching the width of the superview, necessary to create the sliding from the right effect of the banner. The conversation cue position was being modified in the same way, so this change places the cue as a subview of the navigation, preventing it from being moved or getting below the navigation.
Screen.Recording.2025-03-23.at.21.19.26.mov