Skip to content

Add support for ed25519 keys #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ramonpetgrave64
Copy link
Contributor

@ramonpetgrave64 ramonpetgrave64 commented May 9, 2025

Client support for Rekor V2: sigstore-python

Summary

Resolves #1376, #1378

Adds support for ed25519 keys. In the cryptography library, is not yet any support for ed25519ph operations.

Fixes the CI test for timestamp-authority to use the latest release, not the latest tag, since we could have new tags without associated release artifacts to download.

Release Note

  • Added support for ed25519 keys.
  • CI: Timestamp Authority tests use latest release, not latest tag, of
    sigstore/timestamp-authority

Documentation

None

Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as draft May 9, 2025 16:40
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
@ramonpetgrave64 ramonpetgrave64 marked this pull request as ready for review May 9, 2025 20:16
@ramonpetgrave64
Copy link
Contributor Author

@woodruffw @jku

@jku
Copy link
Member

jku commented May 10, 2025

LGTM. Getting this tested should be easy... I don't think there is any problem just editing the trusted_root/trustedroot.v1.json asset and making sure one of the keys is ed25519 (you could add a new log instance for example) -- the test only tests loading the key but it's better than nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ed25519 keys
2 participants