Skip to content

Update PHPUnit to 9.5 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PHPUnit: Added additional void return type
To tearDown, setUpBeforeClass and tearDownAfterClass functions
  • Loading branch information
AntonyThorpe committed Jun 22, 2023
commit 80d64b489fe1ce04068dfa0c0d322ad967b4d95b
2 changes: 1 addition & 1 deletion tests/AuthorizeServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function setUp(): void
]);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion tests/CaptureServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public function setUp(): void
CaptureService::add_extension(PaymentTestServiceExtensionHooks::class);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();
CaptureService::remove_extension(PaymentTestServiceExtensionHooks::class);
Expand Down
2 changes: 1 addition & 1 deletion tests/CreateCardServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function setUp(): void
CreateCardService::add_extension(PaymentTestServiceExtensionHooks::class);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();
CreateCardService::remove_extension(PaymentTestServiceExtensionHooks::class);
Expand Down
2 changes: 1 addition & 1 deletion tests/GatewayInfoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class GatewayInfoTest extends SapphireTest
{
use i18nTestManifest;

protected function tearDown()
protected function tearDown(): void
{
$this->tearDownManifest();
parent::tearDown();
Expand Down
4 changes: 2 additions & 2 deletions tests/PaymentTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ abstract class PaymentTest extends FunctionalTest

protected static $factoryExtensions;

public static function setUpBeforeClass()
public static function setUpBeforeClass(): void
{
parent::setUpBeforeClass();

Expand Down Expand Up @@ -62,7 +62,7 @@ public static function setUpBeforeClass()
Payment::add_extension(PaymentTestPaymentExtensionHooks::class);
}

public static function tearDownAfterClass()
public static function tearDownAfterClass(): void
{
parent::tearDownAfterClass();

Expand Down
2 changes: 1 addition & 1 deletion tests/PurchaseServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public function setUp(): void
PurchaseService::add_extension(PaymentTestServiceExtensionHooks::class);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();

Expand Down
2 changes: 1 addition & 1 deletion tests/RefundServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public function setUp(): void
RefundService::add_extension(PaymentTestServiceExtensionHooks::class);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();
RefundService::remove_extension(PaymentTestServiceExtensionHooks::class);
Expand Down
2 changes: 1 addition & 1 deletion tests/VoidServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public function setUp(): void
VoidService::add_extension(PaymentTestServiceExtensionHooks::class);
}

public function tearDown()
public function tearDown(): void
{
parent::tearDown();
VoidService::remove_extension(PaymentTestServiceExtensionHooks::class);
Expand Down