Fix sorting of stream during full_table sync with composite PK#108
Merged
Fix sorting of stream during full_table sync with composite PK#108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the resumable full_table query is built with the
WHEREclause of the format:In this situation, it doesn't actually replicate all records in the table when resuming, due to the usage of
AND. The set is bounded from below by the latest value for all columns in the PK exclusively, rather than cascading through the PK fields like the behavior ofORDER BY. This PR will change the query building for resuming full_table extraction to be of the form:This will give the tap a true bookmark into the previous, interrupted sync.