Skip to content

Improve ImageEmbedBuilderWeb in example #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Conversation

clia
Copy link
Contributor

@clia clia commented Mar 6, 2023

When using the example in Web browsers, the image is displayed abnormally or not displayed.

The browser debug console outputs:

Height of Platform View type: [https://some.com/some.jpg] may not be set. Defaulting to `height: 100%`.
Set `style.height` to any appropriate value to stop this message.

Width of Platform View type: [https://some.com/some.jpg] may not be set. Defaulting to `width: 100%`.
Set `style.width` to any appropriate value to stop this message.

So I added the width and height style for the image, setting it to 'auto', to make it show properly.

@singerdmx singerdmx merged commit a747e22 into singerdmx:master Mar 6, 2023
@mozartee
Copy link

Because of your setting of auto with width and height, how to set the ImageEmbedBuilderWeb's constraints property?

@clia
Copy link
Contributor Author

clia commented Jun 21, 2023

Because of your setting of auto with width and height, how to set the ImageEmbedBuilderWeb's constraints property?

The behavior of these widths and heights is a bit messy and weird, sometimes they still don't show up, and I don't know how to handle them perfectly. Do you have any good ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants