Skip to content

Improve grid headers #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 7, 2025
Merged

Improve grid headers #1975

merged 35 commits into from
May 7, 2025

Conversation

jpzwarte
Copy link
Member

No description provided.

Copy link
Contributor

github-actions bot commented Apr 16, 2025

🕸 Website preview

You can view a preview here (commit 8275cad6278fdc4f51a6f3bc31341205bf64df56).

Copy link
Contributor

github-actions bot commented Apr 16, 2025

🕸 Storybook preview

You can view a preview here (commit 8275cad6278fdc4f51a6f3bc31341205bf64df56).

Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: 8275cad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@sl-design-system/locales Patch
@sl-design-system/select Patch
@sl-design-system/magister Patch
@sl-design-system/neon Patch
@sl-design-system/sanoma-learning Patch
@sl-design-system/data-source Patch
@sl-design-system/search-field Minor
@sl-design-system/tool-bar Patch
@sl-design-system/checkbox Patch
@sl-design-system/shared Patch
@sl-design-system/grid Minor
@sl-design-system/angular Patch
@sl-design-system/panel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpzwarte jpzwarte marked this pull request as ready for review May 1, 2025 13:43
@jpzwarte jpzwarte requested review from anna-lach and Diaan as code owners May 1, 2025 13:43
@Diaan
Copy link
Collaborator

Diaan commented May 2, 2025

The menu button looks a bit weird when it has the focus:
image
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-basics--menu-button

Lazy load and Skeleton are broken
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-basics--lazy-load
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-basics--skeleton

Dragging and dropping doesn't have any effect on the order (doesn't work on main either, so not sure it's part of this story)
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-drag-and-drop--between

Filtering with datasource seems work on id, not on the displayed text:
image

Filtering with selection is broken (on main as well)
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-filtering--filtering-with-selection

Is the alignment correct when not every column has a filter option?
image

The width of the table doesn't really work anymore :D
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-filtering--empty-values

Grouping is broken: it only adds 1 item in each group, and puts the rest in the last group:
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-grouping--basic
https://github.com/user-attachments/assets/a8ac844e-51dc-4431-bd1c-1fe2db1db375

Horizontal scrolling has 2 scrollbars:
image
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-scrolling--horizontal

Not sure a tri-state toggle button is very good accessibility wise. I don't think the change in label is being announced, so it will be a surprise what the sorting will be when you press it a second time.
https://kind-plant-088739303-1975.westeurope.1.azurestaticapps.net/?path=/story/grid-sorting--basic

@jpzwarte
Copy link
Member Author

jpzwarte commented May 6, 2025

I've fixed everything except:

  • grouping (will look at this in another PR)
  • a11y of sort header; afaict there is nothing to improve there

@jpzwarte jpzwarte merged commit 4a6f8ba into main May 7, 2025
9 of 13 checks passed
@jpzwarte jpzwarte deleted the feature/1968-grid-header branch May 7, 2025 09:50
@jpzwarte jpzwarte linked an issue May 7, 2025 that may be closed by this pull request
@github-actions github-actions bot mentioned this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[grid] Refactor the header to use the new contextual tokens
4 participants