Skip to content

Fix/1875 combobox required validation #2067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 3, 2025

Conversation

Diaan
Copy link
Collaborator

@Diaan Diaan commented May 28, 2025

No description provided.

@Diaan Diaan linked an issue May 28, 2025 that may be closed by this pull request
Copy link

changeset-bot bot commented May 28, 2025

🦋 Changeset detected

Latest commit: 9acc6b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/combobox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 28, 2025

🕸 Website preview

You can view a preview here (commit 9acc6b28ed80a22c1e817d97a45c35903cd1b820).

Copy link
Contributor

github-actions bot commented May 28, 2025

🕸 Storybook preview

You can view a preview here (commit 9acc6b28ed80a22c1e817d97a45c35903cd1b820).

@Diaan Diaan marked this pull request as ready for review June 2, 2025 08:10
@Diaan Diaan requested review from anna-lach and jpzwarte as code owners June 2, 2025 08:10
Copy link
Member

@jpzwarte jpzwarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for it?

@Diaan Diaan merged commit 68ea3c8 into main Jun 3, 2025
13 checks passed
@Diaan Diaan deleted the fix/1875-combobox-required-validation branch June 3, 2025 14:10
@github-actions github-actions bot mentioned this pull request Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[combobox] Required validation does not work properly for multiple
2 participants