Skip to content

Fix #1147 Improve the logic to extract the requestUserId for context objects #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

seratch
Copy link
Contributor

@seratch seratch commented Sep 19, 2024

This pull request resolves #1147

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

@seratch seratch added enhancement M-T: A feature request for new functionality project:bolt labels Sep 19, 2024
@seratch seratch added this to the 1.43.1 milestone Sep 19, 2024
@seratch seratch self-assigned this Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.31%. Comparing base (d5e0036) to head (ac3b54b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...m/slack/api/bolt/request/builtin/EventRequest.java 55.55% 3 Missing and 5 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1375      +/-   ##
============================================
- Coverage     74.39%   74.31%   -0.08%     
- Complexity     4276     4278       +2     
============================================
  Files           461      461              
  Lines         13347    13364      +17     
  Branches       1370     1377       +7     
============================================
+ Hits           9930     9932       +2     
- Misses         2617     2624       +7     
- Partials        800      808       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seratch seratch merged commit 8d83942 into slackapi:main Sep 19, 2024
6 checks passed
@seratch seratch deleted the issue1147-request-user-id branch September 19, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality project:bolt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the logic to extract the requestUserId for context objects
1 participant