Skip to content

prevent f32 overflow #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

prevent f32 overflow #4

merged 1 commit into from
Aug 12, 2022

Conversation

mloubout
Copy link
Member

@mloubout mloubout commented Aug 10, 2022 •
edited
Loading

The l1 projection errors with very long vectors (in 3D) because

julia> lv = 123456578
123456578

julia> length(TF(1.0):TF(1.0):TF(lv)) == lv
false

so this prevents this rounding issue

Also made verbosity an option to avoid lengthy optim logs

@mloubout mloubout added the bug Something isn't working label Aug 10, 2022
@mloubout mloubout force-pushed the f32 branch 3 times, most recently from 6458d67 to bfb9c28 Compare August 11, 2022 00:05
@PetersBas
Copy link
Collaborator

Good point! thanks for the fix.

@PetersBas PetersBas merged commit 8c4b379 into master Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mloubout @PetersBas