Skip to content

Conversation

@TheDeadJoe
Copy link

@TheDeadJoe TheDeadJoe requested review from a team, Zutatensuppe and bustbr and removed request for a team January 15, 2024 12:02
Copy link

@bustbr bustbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only change seems to be this line:
https://github.com/smb-ag/html5lib-php/pull/1/files#diff-86507ddd5551d130ef65a90133dd439230883e8b8c00b9fdad524fcda2af2a33L2207

I can't tell if this property is otherwise unused.
@TheDeadJoe did you grep for it in the code base?

Otherwise lgtm.

@TheDeadJoe
Copy link
Author

the only change seems to be this line:
#1 (files)

Yup. The rest is the IDE doing its job ;)

I can't tell if this property is otherwise unused.
@TheDeadJoe did you grep for it in the code base?

Yes. No occurrences. There is a property called $pendingTableCharactersDirty so at first I thought this could be just a forgotten name change, but in code it's used as a boolean value, so writing there null would make no sense.

@TheDeadJoe TheDeadJoe merged commit 71201ad into master Jan 18, 2024
@TheDeadJoe TheDeadJoe deleted the bugfix/dynamic-property branch January 18, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants