fix: criteria for event stream member detection #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Jun 20, 2025
| @@ -454,7 +452,7 @@ private void generateEventStreamDeserializer(GenerationContext context, UnionSha | |||
| }); | |||
| }); | |||
| }); | |||
| writer.write("return {$$unknown: output};"); | |||
There was a problem hiding this comment.
this fixes a bug introduced in #572
There was a problem hiding this comment.
there's no impact because $unknown events are dropped from the asyncIterable
siddsriv
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corrects the criteria from #1623
http payload trait is not required and the member itself will not have the streaming trait.