fix: add EndpointRequired config resolver to replace CustomEndpoint #1628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
changed the title
kuhe
force-pushed
the
fix/custom-endpoint
branch
from
7818f72 to
a9ab1ab
Compare
siddsriv
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #1589, I added a "default endpoint ruleset" for all clients. This aligned all codegen for consistency and removed edge cases not covered by AWS SDK testing (AWS SDKs all have endpoint rulesets).
In EP2.0, the endpoint input is not required. This makes client calls to
await client.config.endpoint()fail a typecheck, because prior to #1589, a resolver layer called "CustomEndpoint" marked the endpoint input as required when not in the endpoints-ruleset code generation mode.This PR adds backwards compatibility with the
CustomEndpointresolver layer without bringing it back. Here, I add aEndpointRequiredconfig resolver layer when using the default endpoint ruleset.