Adding trailing slash option #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iifawzi <[email protected]>
Contributor
Author
|
what about Line 68 in 917d1d2 |
darrachequesne
pushed a commit
that referenced
this pull request
Jan 10, 2023
The "addTrailingSlash" option allows to control whether a trailing slash is added to the path of the HTTP requests: - true (default): "/engine.io/" - false: "/engine.io" Related: socketio/engine.io-client@21a6e12 Signed-off-by: iifawzi <[email protected]>
Member
|
Merged as d0fd474. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iifawzi [email protected]
Hi, this PR is adding an option to avoid the added trailing slash to the path in the connection as has been done in the engine-client socketio/engine.io-client#694. Resolving socketio/socket.io-client#1550.
The kind of change this PR does introduce
Other information (e.g. related issues)
socketio/socket.io-client#1550