don't send nil parameters to cloudflare #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4k3r
added a commit
that referenced
this pull request
Feb 7, 2015
Don't send nil parameters to cloudflare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently some of my CloudFlare API requests started getting rejected. I traced it to the fact that this library sends parameters with nil arguments, and for many of the commands the library's implementation causes all unset parameters are passed with no argument.
This pull request prevents nil parameters from being passed on to CloudFlare. I've checked the CloudFlare API docs, and there is no defined behavior for setting any parameter without a value anyway, so this change shouldn't cause a problem.