#2030

--force option for slcli file volume-modify command

Author: J Jayasilan

SoftLayer/CLI/file/modify.py

@@ -5,6 +5,7 @@
 import SoftLayer
 from SoftLayer.CLI import environment
 from SoftLayer.CLI import exceptions
+from SoftLayer.CLI import formatting
 
 
 CONTEXT_SETTINGS = {'token_normalize_func': lambda x: x.upper()}
@@ -31,13 +32,19 @@
                    'be 0.25. If original IOPS/GB for the volume is greater than 0.25, new IOPS/GB for the volume '
                    'must also be greater than 0.25.]',
               type=click.Choice(['0.25', '2', '4', '10']))
+@click.option('--force',  default=False, is_flag=True, help="Force modify")
 @environment.pass_env
-def cli(env, volume_id, new_size, new_iops, new_tier):
+def cli(env, volume_id, new_size, new_iops, new_tier, force):
     """Modify an existing file storage volume.
 
     Examples:
             slcli file volume-modify 12345678 --new-size 1000 --new-iops 400
     """
+    if not force:
+        if not (env.skip_confirmations or
+                formatting.confirm("This action will incur charges on your account. Continue?")):
+            raise exceptions.CLIAbort('Aborted')
+
     file_manager = SoftLayer.FileStorageManager(env.client)
 
     if new_tier is not None:

tests/CLI/modules/file_tests.py

@@ -820,3 +820,11 @@ def test_snapshot_get_notification_status(self, status):
     def test_volume_options(self):
         result = self.run_command(['file', 'volume-options'])
         self.assert_no_fail(result)
+
+    @mock.patch('SoftLayer.CLI.formatting.confirm')
+    def test_modify_order_no_force(self, confirm_mock):
+        confirm_mock.return_value = False
+        result = self.run_command(['file', 'volume-modify', '102'])
+
+        self.assertEqual(2, result.exit_code)
+        self.assertEqual('Aborted', result.exception.message)