Skip to content

Example and some sub features were missing in slcli file volume-list, slcli file volume-modify, slcli file volume-options #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramkishor-ch opened this issue Jul 14, 2023 · 1 comment
Assignees
Labels

Comments

@ramkishor-ch
Copy link
Contributor

ramkishor-ch commented Jul 14, 2023

  1. slcli file volume-list
    a. Example was missing, please add it.
    EXAMPLE:
    slcli file volume-list -d dal09 -t endurance --sortby capacity_gb
    This command lists all endurance volumes on current account that are located at dal09, and sorts them by capacity.

b. Options: --notes was missing, please add it.
Options:
-n, --notes Filter by notes

Expected:

./slcli file volume-list --help  
Usage: slcli file volume-list [OPTIONS]

EXAMPLE:
   slcli file volume-list -d dal09 -t endurance --sortby capacity_gb
   This command lists all endurance volumes on current account that are located at dal09, and sorts them by capacity.

        List file storage.

┌────┬────────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ -u │ --username     │ Volume username                                                                                                                        │
│ -n │ --notes     │ Filter by notes                                                                                                                     │      
│ -d │ --datacenter   │ Datacenter shortname                                                                                                                   │
│ -o │ --order        │ Filter by ID of the order that purchased the block storage                                                                             │
│    │ --storage-type │ Type of storage volume Choices: performance, endurance                                                                                 │
│    │ --sortby       │ Column to sort by                                                                                                                      │
│    │ --columns      │ Columns to display. Options: id, username, datacenter, storage_type, capacity_gb, bytes_used, ip_addr, active_transactions,            │
│    │                │ mount_addr, rep_partner_count, created_by, notes                                                                                       │
│ -h │ --help         │ Show this message and exit.                                                                                                            │
└────┴────────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
  1. slcli file volume-modify
    a. Example was missing, please add it.
    EXAMPLE:
    slcli file volume-modify 12345678 --new-size 1000 --new-iops 4000
    This command modify a volume 12345678 with size is 1000GB, IOPS is 4000.
    slcli file volume-modify 12345678 --new-size 500 --new-tier 4
    This command modify a volume 12345678 with size is 500GB, tier level is 4 IOPS per GB.
    b. Options: --force was missing, please add it.
    Options:
    -f, --force Force operation without confirmation

Expected:

./slcli file volume-modify --help
Usage: slcli file volume-modify [OPTIONS] VOLUME_ID

EXAMPLE:
          slcli file volume-modify 12345678 --new-size 1000 --new-iops 4000 
          This command modify a volume 12345678 with size is 1000GB, IOPS is 4000.
          slcli file volume-modify 12345678 --new-size 500 --new-tier 4
          This command modify a volume 12345678 with size is 500GB, tier level is 4 IOPS per GB.

        Modify an existing file storage volume.

┌────┬────────────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│    │ volume-id  │                                                                                                                                            │
│ -f │ --force   │  Force operation without confirmation                                                                              │        
│ -c │ --new-size │ New Size of file volume in GB. ***If no size is given, the original size of volume is used.***                                             │
│    │            │ Potential Sizes: [20, 40, 80, 100, 250, 500, 1000, 2000, 4000, 8000, 12000]                                                                │
│    │            │ Minimum: [the original size of the volume]                                                                                                 │
│ -i │ --new-iops │ Performance Storage IOPS, between 100 and 6000 in multiples of 100 [only for performance volumes] ***If no IOPS value is specified, the    │
│    │            │ original IOPS value of the volume will be used.***                                                                                         │
│    │            │ Requirements: [If original IOPS/GB for the volume is less than 0.3, new IOPS/GB must also be less than 0.3. If original IOPS/GB for the    │
│    │            │ volume is greater than or equal to 0.3, new IOPS/GB for the volume must also be greater than or equal to 0.3.]                             │
│ -t │ --new-tier │ Endurance Storage Tier (IOPS per GB) [only for endurance volumes] ***If no tier is specified, the original tier of the volume will be      │
│    │            │ used.***                                                                                                                                   │
│    │            │ Requirements: [If original IOPS/GB for the volume is 0.25, new IOPS/GB for the volume must also be 0.25. If original IOPS/GB for the       │
│    │            │ volume is greater than 0.25, new IOPS/GB for the volume must also be greater than 0.25.] Choices: 0.25, 2, 4, 10                           │
│ -h │ --help     │ Show this message and exit.                                                                                                                │
└────┴────────────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
  1. slcli file volume-options
    EXAMPLE:
    slcli file volume-options
    This command lists all options for creating a file storage volume, including storage type, volume size, IOPS, tier level, datacenter, and snapshot size.

Expected:

./slcli file volume-options --help
Usage: slcli file volume-options [OPTIONS] [LOCATION]

EXAMPLE:
   slcli file volume-options
   This command lists all options for creating a file storage volume, including storage type, volume size, IOPS, tier level, datacenter, and snapshot size.

        List all options for ordering a block storage

┌────┬──────────┬──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│    │ location │                                                                                                                                              │
│ -p │ --prices │ Use --prices to list the server item prices, and to list the Item Prices by location,add it to the --prices option using location short      │
│    │          │ name, e.g. --prices dal13                                                                                                                    │
│ -h │ --help   │ Show this message and exit.                                                                                                                  │
└────┴──────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
@ramkishor-ch ramkishor-ch changed the title Example and some sub fea Example and some sub features were missing in slcli file volume-list, slcli file volume-modify, slcli file volume-options Jul 14, 2023
JayasilanJibm pushed a commit that referenced this issue Jul 21, 2023
Examples included for slcli file volume-list, volume-modify, volume-options command
JayasilanJibm pushed a commit that referenced this issue Jul 21, 2023
tox specific fix for slcli file volume-list, volume-modify, volume-options command
@JayasilanJibm
Copy link
Contributor

@allmightyspiff

  1. For volume-list, do we need notes. I could not see the same in the master branch.
  2. For volume-modify, do we need to use --force options. Please suggest on the implications if force change it before we can make these changes.

Thanks,
Jayasilan

JayasilanJibm pushed a commit that referenced this issue Jul 21, 2023
--force option for slcli file volume-modify command
@JayasilanJibm JayasilanJibm self-assigned this Aug 17, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Q3 2023 Aug 17, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Q3 2023 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
3 participants