Skip to content

some sub features are missing slcli firewall add, slcli firewall cancel #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramkishor-ch opened this issue Jul 14, 2023 · 0 comments · Fixed by #2052
Closed

some sub features are missing slcli firewall add, slcli firewall cancel #2032

ramkishor-ch opened this issue Jul 14, 2023 · 0 comments · Fixed by #2052
Assignees
Labels

Comments

@ramkishor-ch
Copy link
Contributor

  1. slcli firewall add
    Options: --force was missing, please add it and interchange position from --high availability to -ha.
    --force Force operation without confirmation
    -ha --high-availability High available firewall option

Expected:

./slcli firewall add --help        
Usage: slcli firewall add [OPTIONS] TARGET

        Create new firewall.

TARGET: Id of the server the firewall will protect

┌─────────────────────┬─────────────────┬─────────────────────────────────────────────────────┐
│                     │ target          │                                                     │
│                     │ --firewall-type │ Firewall type  [required] Choices: vs, vlan, server │
│ -ha │ --high-availability             │ High available firewall option                      │
│ -h                  │ --help          │ Show this message and exit.                         │
│                   │ --force          │ Force operation without confirmation                        │
└─────────────────────┴─────────────────┴─────────────────────────────────────────────────────┘
  1. slcli firewall cancel
    Options: --force was missing, please add it.

Options:
--force Force operation without confirmation

Expected:

./slcli firewall cancel --help
Usage: slcli firewall cancel [OPTIONS] IDENTIFIER

        Cancels a firewall.

┌────┬─────────────────┬─────────────────────────────────────────────────────────────────┐
│    │ identifier      │                                                                 │
│    │ --firewall-type │ Firewall type.  [default: vlan; required] Choices: vlan, server │
│    │ --force   │Force operation without confirmation                      │
│ -h │ --help          │ Show this message and exit.                                     │
└────┴─────────────────┴─────────────────────────────────────────────────────────────────┘
JayasilanJibm pushed a commit that referenced this issue Jul 21, 2023
--force option for slcli firewall add, firewall cancel command
@JayasilanJibm JayasilanJibm self-assigned this Jul 21, 2023
allmightyspiff added a commit that referenced this issue Jul 27, 2023
--force option for slcli firewall add, firewall cancel command - issue #2032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants