Skip to content
This repository was archived by the owner on Jun 9, 2025. It is now read-only.

update minikube overlay with cluster role bindings #2027

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

davejrt
Copy link
Contributor

@davejrt davejrt commented Mar 9, 2021

fixes:

Error from server (Invalid): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"rbac.authorization.k8s.io/v1\",\"kind\":\"ClusterRoleBinding\",\"metadata\":{\"annotations\":{},\"labels\":{\"app\":\"cadvisor\",\"app.kubernetes.io/component\":\"cadvisor\",\"category\":\"rbac\",\"deploy\":\"sourcegraph\",\"sourcegraph-resource-requires\":\"cluster-admin\"},\"name\":\"cadvisor\"},\"roleRef\":{\"apiGroup\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"cadvisor\"},\"subjects\":[{\"kind\":\"ServiceAccount\",\"name\":\"cadvisor\"}]}\n"}},"subjects":[{"kind":"ServiceAccount","name":"cadvisor"}]}
to:
Resource: "rbac.authorization.k8s.io/v1, Resource=clusterrolebindings", GroupVersionKind: "rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding"
Name: "cadvisor", Namespace: ""
for: "base/cadvisor/cadvisor.ClusterRoleBinding.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "cadvisor" is invalid: subjects[0].namespace: Required value
Error from server (Invalid): error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"rbac.authorization.k8s.io/v1\",\"kind\":\"ClusterRoleBinding\",\"metadata\":{\"annotations\":{},\"labels\":{\"app.kubernetes.io/component\":\"prometheus\",\"category\":\"rbac\",\"deploy\":\"sourcegraph\",\"sourcegraph-resource-requires\":\"cluster-admin\"},\"name\":\"prometheus\"},\"roleRef\":{\"apiGroup\":\"rbac.authorization.k8s.io\",\"kind\":\"ClusterRole\",\"name\":\"prometheus\"},\"subjects\":[{\"kind\":\"ServiceAccount\",\"name\":\"prometheus\"}]}\n"}},"subjects":[{"kind":"ServiceAccount","name":"prometheus"}]}
to:
Resource: "rbac.authorization.k8s.io/v1, Resource=clusterrolebindings", GroupVersionKind: "rbac.authorization.k8s.io/v1, Kind=ClusterRoleBinding"
Name: "prometheus", Namespace: ""
for: "base/prometheus/prometheus.ClusterRoleBinding.yaml": ClusterRoleBinding.rbac.authorization.k8s.io "prometheus" is invalid: subjects[0].namespace: Required value

@davejrt davejrt requested a review from a team March 9, 2021 19:12
Copy link
Contributor

@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you for keeping this up to date!

@davejrt davejrt merged commit 9897962 into master Mar 9, 2021
@davejrt davejrt deleted the dt/clusterrolesbindings branch March 9, 2021 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants