This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Add divisor to resourceFieldRef’s that expect a value in MB instead of bytes #4016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caugustus-sourcegraph let's pair tomorrow and I'll show you how i was testing this the other day |
davejrt
approved these changes
Nov 9, 2021
alejandrom-eb
referenced
this pull request
in eventbrite/deploy-sourcegraph
Dec 10, 2021
v3.34.1 * tag 'v3.34.1': release: [email protected] (#4028) release: [email protected] (#4024) OSS license and disclaimer (#3847) Add divisor to resourceFieldRef’s that expect a value in MB instead of bytes (#4016) fixes fsgroup id (#4021) tools: in-place image updates (#4019) Drop liveness probes (#2970)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/sourcegraph/sourcegraph/issues/26283.
Limits and requests for ephemeral-storage are measured in bytes, and the SEARCHER_CACHE_SIZE_MB / SYMBOLS_CACHE_SIZE_MB var's expect a unit of MB.
Caveats:
Tested by filling up the disk using dd
Not a concern, because caches are per-pod and get recreated on every deployment
Checklist