Skip to content

style(clang-tidy): disable performance-enum-size #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

style(clang-tidy): disable performance-enum-size #1751

merged 1 commit into from
Jun 23, 2025

Conversation

bavulapati
Copy link
Contributor

fixes #1682

Clang-tidy does notifies the performance benefit of usign smaller data type for enum but doesn't recognize the proper usage.

@bavulapati
style(clang-tidy): disable performance-enum-size
11a9736 
fixes sourcemeta#1682

Clang-tidy does notifies the performance benefit of usign smaller data type
for enum but doesn't recognize the proper usage.

Signed-off-by: Balakrishna Avulapati <[email protected]>
@jviotti jviotti merged commit 9b1a0ba into sourcemeta:main Jun 23, 2025
14 checks passed
@bavulapati
Copy link
Contributor Author

@jviotti Would like to revisit the recently disabled checks after #1754
Expect PR with some of the checks disabled to be re-enabled, if we notice a different error reporting after #1754

@bavulapati bavulapati deleted the disable-performance-enum-size branch June 23, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ClangTidy warnings for performance-enum-size
2 participants
@bavulapati @jviotti