chore(package.json): add packageManager
#638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunsetTechuila
requested review from
theRealPadster
and removed request for
a team
Contributor
Author
|
@theRealPadster did you read the pr description? |
Member
Yes. It sounded to me like you were going to make the scripts use pnpm, but then I looked and it's changing it back to npm |
rxri
changed the title
packageManager && make scripts pm-independentpackageManager
theRealPadster
requested changes
Nov 4, 2023
Co-authored-by: Isaac <[email protected]>
theRealPadster
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not needed if the version is specified in package.json
link
there is no reason to have 20 here, check the dependencies. npm and pnpm only show a warning, but yarn throws an error if you have the node ver less than 20
why have pnpm here if we don't force to use it?