This repository was archived by the owner on May 31, 2022. It is now read-only.
make redirect resolver configureable by endpoint config #1190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually its hard to customise the
RedirectResolverfor the correspondingAuthorizationEndpoint(at least for my setup?).For example I have one config
AuthorizationServerConfigurationwhich extendsAuthorizationServerConfigurerAdapterand configures theAuthorizationEndpointusingconfigure(AuthorizationServerEndpointsConfigurer configurer)At the moment I'm not able to pass in a
RedirectResolverto the configurer. Since I'm also configuring a CompositeTokenGranter which requires the AuthorizationEndpoint I'm also not able to inject the endpoint and callsetRedirectResolver. Even when usingPostConstructit wont work until I create a separate configuration class for this. All dependencies (required byAuthorizationServerConfiguration) are initialised in one configuration (AuthorizationEndpoint doesnt exist at this point) and usingPostConstructin myAuthorizationServerConfigurationcauses a cyclic dependency.The only way I see is to create my own
AuthorizationEndpointbased on the existing one and use a qualifier/primary for my custom one...Is there maybe a straight forward way to set the redirect resolver without that change? I'd love to make it possible to configure it by using the
AuthorizationServerEndpointsConfigurer. Thanks(actually I've no clue whats wrong with the tests at travis .. :/)