Skip to content
This repository was archived by the owner on May 31, 2022. It is now read-only.

Conversation

@etwillbefine
Copy link
Contributor

@etwillbefine etwillbefine commented Oct 18, 2017

Actually its hard to customise the RedirectResolver for the corresponding AuthorizationEndpoint (at least for my setup?).

For example I have one config AuthorizationServerConfiguration which extends AuthorizationServerConfigurerAdapter and configures the AuthorizationEndpoint using configure(AuthorizationServerEndpointsConfigurer configurer)

At the moment I'm not able to pass in a RedirectResolver to the configurer. Since I'm also configuring a CompositeTokenGranter which requires the AuthorizationEndpoint I'm also not able to inject the endpoint and call setRedirectResolver. Even when using PostConstruct it wont work until I create a separate configuration class for this. All dependencies (required by AuthorizationServerConfiguration) are initialised in one configuration (AuthorizationEndpoint doesnt exist at this point) and using PostConstruct in my AuthorizationServerConfiguration causes a cyclic dependency.

The only way I see is to create my own AuthorizationEndpoint based on the existing one and use a qualifier/primary for my custom one...

Is there maybe a straight forward way to set the redirect resolver without that change? I'd love to make it possible to configure it by using the AuthorizationServerEndpointsConfigurer. Thanks

(actually I've no clue whats wrong with the tests at travis .. :/)

@pivotal-issuemaster
Copy link

@etwillbefine Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@etwillbefine Thank you for signing the Contributor License Agreement!

@etwillbefine etwillbefine force-pushed the redirect-resolver-conf branch from e282510 to ebf0574 Compare October 18, 2017 17:32
@etwillbefine
Copy link
Contributor Author

Is that something which could/will be merged or not?

@jgrandja jgrandja added this to the 2.3.0.RC1 milestone Feb 12, 2018
@jgrandja jgrandja self-assigned this Feb 12, 2018
@jgrandja jgrandja closed this in e5dab23 Feb 12, 2018
@jgrandja
Copy link
Contributor

Thanks for the PR @etwillbefine.
I applied some minor polish and merged to master.
Scheduled for 2.3.0.RC1 on Feb 27.

@etwillbefine
Copy link
Contributor Author

Thanks for taking care!

@etwillbefine etwillbefine deleted the redirect-resolver-conf branch February 13, 2018 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants