Skip to content

Warnings when used with jsp #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
semeiser opened this issue Oct 20, 2016 · 2 comments
Closed

Warnings when used with jsp #427

semeiser opened this issue Oct 20, 2016 · 2 comments
Milestone
1.0.12

Comments

@semeiser
Copy link

Hello,

I get the following warnings in the log when using sleuth with jsps, seems to be one line per included jsp, per request:

2016-10-20 10:44:28.288  WARN [-,,,] 72523 --- [nio-8080-exec-1] o.s.cloud.sleuth.util.ExceptionUtils     : Tried to close span but it is not the current span: [Trace: 4638aa2540b6c27b, Span: 4638aa2540b6c27b, Parent: null, exportable:false].  You may have forgotten to close or detach [Trace: 4638aa2540b6c27b, Span: a55e2f71e64e73e4, Parent: 4638aa2540b6c27b, exportable:false]
2016-10-20 10:44:28.291  WARN [-,,,] 72523 --- [nio-8080-exec-1] o.s.cloud.sleuth.util.ExceptionUtils     : Tried to close span but it is not the current span: [Trace: 4638aa2540b6c27b, Span: 4638aa2540b6c27b, Parent: null, exportable:false].  You may have forgotten to close or detach [Trace: 4638aa2540b6c27b, Span: a55e2f71e64e73e4, Parent: 4638aa2540b6c27b, exportable:false]
2016-10-20 10:44:28.306  WARN [-,,,] 72523 --- [nio-8080-exec-1] o.s.cloud.sleuth.util.ExceptionUtils     : Tried to close span but it is not the current span: [Trace: 4638aa2540b6c27b, Span: 4638aa2540b6c27b, Parent: null, exportable:false].  You may have forgotten to close or detach [Trace: 4638aa2540b6c27b, Span: a55e2f71e64e73e4, Parent: 4638aa2540b6c27b, exportable:false]

A minimal demo producing the above output (to be run in tomcat container) can be found at https://github.com/semeiser/sleuthjspdemo .

Is there something I can configure to mitigate this issue?

Thank you for any help :)
@gavlyukovskiy
Copy link
Contributor

Hi, faced same issue #469.
There are exmplanation of why it happens, but I don't know how it should be fixed and seems like there are no workaround for it.

This was referenced Dec 14, 2016
Closed
Merged
marcingrzejszczak added a commit that referenced this issue Dec 16, 2016
@marcingrzejszczak
Spans are continued in Handler Interceptors (#474)
ee8c73d 
without this change an explicit new span is created on the server side. Its name is equal to the method name of the controller. It introduces some nice advantages in terms of readability of trace.

with this change we're continuing a previous span on the server side. We're attaching the tags and logs to that span with information about controller class and controller name. Also events related to start and finish of the controller are there.

fixes #471 #469 #427
@marcingrzejszczak marcingrzejszczak added this to the 1.0.12 milestone Dec 16, 2016
@marcingrzejszczak
Copy link
Contributor

Done via ee8c73d

marcingrzejszczak added a commit that referenced this issue Dec 16, 2016
@marcingrzejszczak
Spans are continued in Handler Interceptors (#474)
9c5c965 
without this change an explicit new span is created on the server side. Its name is equal to the method name of the controller. It introduces some nice advantages in terms of readability of trace.

with this change we're continuing a previous span on the server side. We're attaching the tags and logs to that span with information about controller class and controller name. Also events related to start and finish of the controller are there.

fixes #471 #469 #427
marcingrzejszczak added a commit that referenced this issue Dec 16, 2016
@marcingrzejszczak
Spans are continued in Handler Interceptors (#474)
1b832b6 
without this change an explicit new span is created on the server side. Its name is equal to the method name of the controller. It introduces some nice advantages in terms of readability of trace.

with this change we're continuing a previous span on the server side. We're attaching the tags and logs to that span with information about controller class and controller name. Also events related to start and finish of the controller are there.

fixes #471 #469 #427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.12
Development

No branches or pull requests
3 participants
@semeiser @marcingrzejszczak @gavlyukovskiy