Use ThreadLocal.remove() rather than .set(null) #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me :) |
spencergibb
added a commit
that referenced
this pull request
Aug 18, 2015
Use ThreadLocal.remove() rather than .set(null)
|
@rwinch @spencergibb I think the memory leak is not caused by ThreadLocal.set(null), because theadLocalMap just hold the weak reference of ThreadLocal variable, the strong relationship held is by the thread itself. |
|
You're referring to the code that is 6 years old. There's no such code anymore! |
|
It's okay, I just wanna to confirm that ThreadLocal.set(null) cannot cause memory leaks. |
|
And I am certain that the code is never changed since 6 years ago. |
|
@cincat there's no such class |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes gh-27
/cc @rwinch