This repository was archived by the owner on Aug 8, 2024. It is now read-only.
Fix Unexpected Error on invalid JSON passed as request body #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stringify the invalid json response
|
Hey, thanks again for the PR. We were thinking that rather than just returning a string it might be better to return a real object, e.g. What do you think? |
|
Good point. I will merge this PR and creates an new one. Thanks @mintuz |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again 👋 we've been using this library now for a couple of weeks now and noticed an issue when passing invalid json as the request object, causes an unexpected error to be thrown with the message
unexpected token b in JSONThis PR is to fix that, this is done by stringifying the response.