Add tests for LastMaxTokenSizeContentPurger #3293
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR introduces unit tests for
LastMaxTokenSizeContentPurger
, following up on the discussion in issue #2894.While working on the tests, I encountered a particular scenario regarding the
totalSize
parameter that I'd like to clarify. It seems that iftotalSize
is passed in with a value smaller than the actual sum of estimateTokenCount for theList<MediaContent> datum
, the current logic might not perform the expected purging.For example, if
datum
contains items with token counts (total 120), andpurgeExcess()
is called with totalSize (100) and maxTokenSize (100), the initial while loop condition(totalSize > this.maxTokenSize)
would be false. Consequently, no items fromdatum
would be purged, potentially leading to the final token count exceedingmaxTokenSize
.Is this behavior intended, or is there something I might be overlooking regarding how
totalSize
is expected to be calculated and passed to this method?Thanks!