feat: Add tool_calls support to JdbcChatMemoryRepository #3343
+219
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astor-dev
force-pushed
the
feat-jdbc-memory-tool-calls
branch
from
cbf3844 to
f11ac75
Compare
- Add tool_calls column to all database schemas (PostgreSQL, MySQL, SQL Server, HSQLDB) - Implement JSON serialization/deserialization for AssistantMessage.ToolCall objects - Update all dialect classes to include tool_calls in SELECT and INSERT queries - Add PostgreSQL JSONB type support with explicit casting (::jsonb) - Add comprehensive unit tests for tool calls functionality - Add integration tests for tool calls across all supported databases - Maintain backward compatibility with existing chat memory data This enhancement allows the JDBC chat memory repository to persist and retrieve tool call information from AI assistant messages, enabling full conversation context preservation including function calls and their metadata. Signed-off-by: astor-dev <[email protected]>
astor-dev
force-pushed
the
feat-jdbc-memory-tool-calls
branch
from
f11ac75 to
18eda40
Compare
|
Thanks for this, I need to spend more time reviewing this, but in the 1.0.x branch we won't be able to merge any schema breaking changed, we can for 1.1.x No firm timeline on the 1.1.x release date yet, just starting to review what we can do and publish a public roadmap. |
essien
reviewed
May 31, 2025
| case ASSISTANT -> new AssistantMessage(content); | ||
| case ASSISTANT -> { | ||
| List<AssistantMessage.ToolCall> toolCalls = List.of(); | ||
| if (toolCallsJson != null && !toolCallsJson.trim().isEmpty()) { |
There was a problem hiding this comment.
trim() is not aware of unicode whitespace characters and so strip() is the preferred way to remove whitespace characters since Java 11.
For this specific case, you can use isBlank() which is available since Java 11 and also unicode aware.
Suggested modification:
- !toolCallsJson.trim().isEmpty()
+ !toolCallsJson.isBlank()There was a problem hiding this comment.
Got it, updated to isBlank() as suggested. Thanks!
…icode whitespace in JdbcChatMemoryRepository Signed-off-by: astor-dev <[email protected]>
astor-dev
force-pushed
the
feat-jdbc-memory-tool-calls
branch
from
d4aee39 to
54da813
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for persisting
tool_callsinJdbcChatMemoryRepositoryto resolve issues with tool calling functionality in JDBC-based chat memory implementations.Issues Addressed
Fixes #3342 - Support persisting tool_calls in JdbcChatMemoryRepository
It can also serve as a preliminary step to fix the issues below:
#3339 - ToolResponseMessage results in null content, causing SQLIntegrityConstraintViolationException
Changes
Database Schema
tool_callscolumn to all database schemas (PostgreSQL, MySQL, SQL Server, HSQLDB)JSONBtype with explicit::jsonbcastingTEXT/LONGVARCHARfor JSON storageImplementation
List<AssistantMessage.ToolCall>to JSON on inserttool_callsin SELECT and INSERT queriesDatabase Dialects Updated
PostgresChatMemoryRepositoryDialectMysqlChatMemoryRepositoryDialectSqlServerChatMemoryRepositoryDialectHsqldbChatMemoryRepositoryDialect