safely merge empty tool call name case(streaming mode) #4588
+86
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Feng Xie[email protected]
Overview
The PR is to add a private method
safelyMergeAssistantMessageIfEmptyToolCallPresent
processes and merges tool calls in an AssistantMessage, particularly handling cases where tool calls might have empty name or fragmented arguments due to streaming or other processing issues.Key Logic of
safelyMergeAssistantMessageIfEmptyToolCallPresent
StringUtils.hasText(toolCall.name())
check prevents invalid tool call exceptionsSafety Mechanism
StringUtils.hasText(toolCall.name())
serves as a guard to:Result
Returns new AssistantMessage with merged tool calls, preserving original content, media, and metadata.