Skip to content

Support to read configuration properties description from super class #45381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
quaff opened this issue May 7, 2025 · 3 comments
Closed

Support to read configuration properties description from super class #45381

quaff opened this issue May 7, 2025 · 3 comments
Labels
status: duplicate A duplicate of another issue

Comments

@quaff
Copy link
Contributor

quaff commented May 7, 2025

Given:

public class BaseProperties {
	/**
	 * Schema to use.
	 */
	private String schema;

	public String getSchema() {
		return this.schema;
	}

	public void setSchema(String schema) {
		this.schema = schema;
	}
}
@ConfigurationProperties("my")
public class MyProperties extends BaseProperties  {
}

Here is error:

build/classes/java/main/META-INF/spring-configuration-metadata.json

The following properties have no description:

	my.schema

See https://github.com/spring-projects/spring-boot/actions/runs/14873950901/job/41767618541?pr=45379

@wilkinsona
Copy link
Member

Duplicates #18366. The problem's not that it's a super-class but that it's in another module.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale May 7, 2025
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels May 7, 2025
quaff added a commit to quaff/spring-boot that referenced this issue May 7, 2025
@quaff
Copy link
Contributor Author

quaff commented May 7, 2025

Duplicates #18366. The problem's not that it's a super-class but that it's in another module.

Indeed it's not super-class problem, I improve existing test to cover that, is it worth to submit PR? @wilkinsona

@wilkinsona
Copy link
Member

Yes, please. A PR against 3.3.x that adds some assertions for the descriptions coming from super-classes would be great.

quaff added a commit to quaff/spring-boot that referenced this issue May 7, 2025
quaff added a commit to quaff/spring-boot that referenced this issue May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants