Skip to content

Add support for property spring.test.database.replace #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eddumelendez
Copy link
Contributor

See gh-7229

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 3, 2016
@eddumelendez eddumelendez reopened this Dec 3, 2016
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 5, 2016
@philwebb philwebb added this to the 1.5.0 RC1 milestone Dec 5, 2016
@snicoll
Copy link
Member

snicoll commented Dec 16, 2016

@eddumelendez I am confused. I've reverted those two custom conditions and all the tests pass. I fail to see why you need this, can you please clarify?

@snicoll snicoll self-assigned this Dec 16, 2016
@snicoll snicoll added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 16, 2016
snicoll added a commit that referenced this pull request Dec 16, 2016
* pr/7560:
  Polish contribution
  Add support for property spring.test.database.replace
@snicoll snicoll closed this in 21b815a Dec 16, 2016
@eddumelendez
Copy link
Contributor Author

@snicoll when I was doing this, I wasn't aware of @PropertyMapping. That's the reason why I added these custom conditions, I didn't verify the behaviour without them. Thanks to polish my contribution 👍

@eddumelendez eddumelendez deleted the gh-7229 branch January 17, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants