DATAREDIS-676 - Pass on configured command timeout to LettuceClusterConnection. #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection. We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the LettuceClusterConnection.
Simplify command timeout access. Set disposal state in LettuceClusterConnection only once. Close resources after tests.
mp911de
force-pushed
the
issue/DATAREDIS-676
branch
from
9b2e330 to
c9a1384
Compare
mp911de
pushed a commit
that referenced
this pull request
Aug 21, 2017
…onnection. We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the LettuceClusterConnection. Original pull request: #266.
mp911de
added a commit
that referenced
this pull request
Aug 21, 2017
Set disposal state in LettuceClusterConnection only once. Close resources after tests. Typos, formatting. Original pull request: #266.
mp911de
pushed a commit
that referenced
this pull request
Aug 21, 2017
…onnection. We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the LettuceClusterConnection. Original pull request: #266.
mp911de
added a commit
that referenced
this pull request
Aug 21, 2017
Set disposal state in LettuceClusterConnection only once. Close resources after tests. Typos, formatting. Original pull request: #266.
mp911de
pushed a commit
that referenced
this pull request
Aug 21, 2017
…onnection. We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the LettuceClusterConnection. Original pull request: #266.
mp911de
added a commit
that referenced
this pull request
Aug 21, 2017
Set disposal state in LettuceClusterConnection only once. Close resources after tests. Typos, formatting. Original pull request: #266.
mp911de
pushed a commit
that referenced
this pull request
Aug 21, 2017
…onnection. We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the LettuceClusterConnection. Original pull request: #266.
mp911de
added a commit
that referenced
this pull request
Aug 21, 2017
Simplify command timeout access. Set disposal state in LettuceClusterConnection only once. Close resources after tests. Original pull request: #266.
|
That's merged and back ported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now not only configure the underlying lettuce connection with the command timeout set via the connection factory, but also make sure to pass the option on to the
LettuceClusterConnection.