DATAREDIS-830 - Release Pub/Sub connection when closing LettuceSubscription #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iption. We now release the native connection back to the connection provider when LettuceSubscription is closed. Previously, we just closed the connection which interfered with pooling as pooling connection providers still had a reference on the connection.
Reformat code. Add override-comments. Encapsulate connection in LettuceSubscription. Fix typos.
christophstrobl
pushed a commit
that referenced
this pull request
May 22, 2018
…iption. We now release the native connection back to the connection provider when LettuceSubscription is closed. Previously, we just closed the connection which interfered with pooling as pooling connection providers still had a reference on the connection. Original Pull Request: #341
christophstrobl
pushed a commit
that referenced
this pull request
May 22, 2018
Reformat code. Add override-comments. Encapsulate connection in LettuceSubscription. Fix typos. Original Pull Request: #341
christophstrobl
added a commit
that referenced
this pull request
May 22, 2018
Move Subscription initialization and update comments. Original Pull Request: #341
christophstrobl
pushed a commit
that referenced
this pull request
May 22, 2018
…iption. We now release the native connection back to the connection provider when LettuceSubscription is closed. Previously, we just closed the connection which interfered with pooling as pooling connection providers still had a reference on the connection. Original Pull Request: #341
christophstrobl
pushed a commit
that referenced
this pull request
May 22, 2018
Reformat code. Add override-comments. Encapsulate connection in LettuceSubscription. Fix typos. Original Pull Request: #341
christophstrobl
added a commit
that referenced
this pull request
May 22, 2018
Move Subscription initialization and update comments. Original Pull Request: #341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now release the native connection back to the connection provider when
LettuceSubscriptionis closed. Previously, we just closed the connection which interfered with pooling as pooling connection providers still had a reference to the connection.We should backport this one to 2.0.x.
Related ticket: DATAREDIS-830.