Wrong check at SwitchUserFilter#setSwitchFailureUrl()

[martin-g]

Summary

org.springframework.security.web.authentication.switchuser.SwitchUserFilter#setSwitchFailureUrl() makes a check for non-empty this.switchUserUrl instead of the passed switchFailureUrl. The error message says: "switchFailureUrl cannot be empty and must be a valid redirect URL" so I believe the check is wrong (copy/paste error ?!).

Actual Behavior

Checks for non-empty this.switchUserUrl

Expected Behavior

Should check for non-empty switchFailureUrl

Configuration

Irrelevant

Version

4.1.4

Sample

spring-security/web/src/main/java/org/springframework/security/web/authentication/switchuser/SwitchUserFilter.java

Line 498 in 9c03571

StringUtils.hasText(this.switchUserUrl)

[rwinch]

Thanks for the report! A fix is now merged into master :)