Skip to content

Conversation

henriquels25
Copy link
Contributor

  • Add a post endpoint in /messages
  • Changes the security config to require the read scope to GET a message and the write scope
    to POST a new message.
  • Changes the jwks of the mock server so I could create a new access token with the write scope.
  • Creates tests and integration-tests for the POST endpoint.
  • Changes the README to add an example of a POST request.

Fixes gh-7118

@henriquels25 henriquels25 changed the title Add test examples for the POST http method in the oauth2 resource ser… Add test examples for Oauth2 Resource Server sample Jul 27, 2019
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 27, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Jul 31, 2019

Thanks, @henriquels25! This looks great.

In preparation for merging, will you please shorten your commit message to be 50 characters or below?

- Add a post endpoint in /messages
- Changes the security config to require the read scope to GET a message and the write scope
to POST a new message.
- Changes the jwks of the mock server so I could create a new access token with the write scope.
- Creates tests and integration-tests for the POST endpoint.
- Changes the README to add an example of a POST request.

Fixes spring-projectsgh-7118
@henriquels25
Copy link
Contributor Author

I changed the commit message @jzheaux.

@jzheaux jzheaux self-assigned this Aug 5, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 5, 2019
@jzheaux jzheaux added this to the 5.2.0.RC1 milestone Aug 5, 2019
@jzheaux jzheaux merged commit da62c31 into spring-projects:master Aug 6, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 6, 2019

Thanks, @henriquels25! This is now merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve OAuth2 Resource Server tests

3 participants