Add setContentLengthLong detection to OnCommittedResponseWrapper. #7264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: web
|
Thanks, @danielwegener, for the PR! In preparation for merging, would you please update your commit message to follow the contribution guidelines? |
jzheaux
added
the
status: waiting-for-feedback
Add setContentLengthLong tracking to OnCommittedResponseWrapper in order to detect commits on servlets that use setContentLengthLong to announce the entity size they are about to write (as used in the Apache Tomcat's DefaultServlet). Fixes gh-7261
|
@jzheaux Good point, sorry, wasn't reading the guildelines carefully enough. CLA is signed. |
spring-projects-issues
added
status: feedback-provided
|
Thanks, @danielwegener! This is now merged into |
|
Thanks @jzheaux, that's great! Is there any chance this could find a way down into 5.1.7? |
|
Yes, @danielwegener, I've just backported it via f28fe2d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-#7261
Trivial implementation.