Fix unchecked assignment and possible NPE #7773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Jan 2, 2020
There was a problem hiding this comment.
Thanks for the PR @rafaelrenanpacheco! I have left a few comments inline regarding the indentation.
docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc
Outdated
Show resolved
Hide resolved
docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc
Outdated
Show resolved
Hide resolved
docs/manual/src/docs/asciidoc/_includes/servlet/oauth2/oauth2-resourceserver.adoc
Outdated
Show resolved
Hide resolved
docs/manual/src/docs/asciidoc/_includes/reactive/oauth2/resource-server.adoc
Outdated
Show resolved
Hide resolved
eleftherias
added
in: docs
|
Sorry about that, I didn't see the default "Tabs" option when changing files directly on Github. Should be all spaces now 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unchecked exception if fixed by casting to
Collection<?>instead ofCollection<String>and casting each item withObject::toStringprior theSimpleGrantedAuthorityinstantiation.The possible NPE is fixed by returning
Collections.emptyList()if the custom claim is missing in the JWT.